fix: change testing strategdy to compare against graphql-ws #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
reconbot
commented
Aug 21, 2021
reconbot
commented
- fix error handling for validation and execution execution context errors to send an Error message
- change the onSubscribe Callback to send an Error message to allow denying a subscription without trashing the connection
- change the testing execution helper to have a stream of websocket events instead of using the graphql-ws client, this lets us more easily compare outputs between the servers
- port testing to a branch of the arc sandbox that fully supports the api gateway management api (feat: api gateway management api on /_arc/ws architect/sandbox#640)
reconbot
force-pushed
the
reconbot/fix-errors-and-test-more
branch
from
a48fc26 to
02b2a10
Compare
- fix error handling for validation and execution execution context errors to send an Error message - change the onSubscribe Callback to send an Error message to allow denying a subscription without trashing the connection - change the testing execution helper to have a stream of websocket events instead of using the graphql-ws client, this lets us more easily compare outputs between the servers - port testing to a branch of the arc sandbox that fully supports the api gateway management api (architect/sandbox#640)
reconbot
force-pushed
the
reconbot/fix-errors-and-test-more
branch
from
02b2a10 to
8456103
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.