Skip to content

Getty TGN tag added to original annotation instead of reply #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamiefolsom opened this issue May 20, 2025 · 4 comments
Open

Getty TGN tag added to original annotation instead of reply #4

jamiefolsom opened this issue May 20, 2025 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jamiefolsom
Copy link
Member

Screen.Recording.2025-05-20.at.09.51.46.mov
@jamiefolsom jamiefolsom added the bug Something isn't working label May 20, 2025
@rsimon
Copy link
Member

rsimon commented May 20, 2025

We generally do not have tags on replies. The correct fix would actually be in the plugin, i.e. show the button only for the top annotation card section.

@jamiefolsom
Copy link
Member Author

We generally do not have tags on replies. The correct fix would actually be in the plugin, i.e. show the button only for the top annotation card section.

OK. This is the plugin repo, though -- should the issue be on the template repo?

@rsimon
Copy link
Member

rsimon commented May 20, 2025

No–it's an issue of the plugin, so that's the right place 👍

@rsimon
Copy link
Member

rsimon commented May 21, 2025

This is now fixed.

For context:

The behavior above was simply because that's the way Recogito annotations are structured, and how the extension point worked.

  • Tags are always appended at the top. (Technically, they are neither associated with a particular comment or reply. They are separate annotation bodies, and we show them at the top.)
  • The extension point appended the Getty tag widget at the bottom of the annotation card, making UX awkward.

The fix:

The fix for this issue was mostly in the Recogito client:

  • I added a new extension point that's co-located with the tag editor (rather than appended to the bottom of the annotation card)
  • That new extension point appears only if the standard tag editor appears (on new annotations, or when the annotation owner edits an existing annotation), making UX consistent with the default tagging widget.

Note that the following steps are required before this is testable:

  • Recogito Client PR 378 must be merged to develop (and develop must be deployed on the test system).
  • Latest version of this plugin must be deployed on the test system (0.9.4+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants