Merge pull request #766 from mfn/mfn-dont-catch

Don't catch SchemaNotFound

Author: mfn

CHANGELOG.md

@@ -101,6 +101,7 @@ CHANGELOG
 - Laravels `ValidationException` is now formatted the same way as a `ValidationError` [\#748 / mfn](https://github.com/rebing/graphql-laravel/pull/748)
 
 ### Changed
+- Don't silence broken schemas when normalizing them for generating routes [\#766 / mfn](https://github.com/rebing/graphql-laravel/pull/766)
 - Lazy loading types has been enabled by default [\#758 / mfn](https://github.com/rebing/graphql-laravel/pull/758)
 
 2021-04-10, 7.2.0

src/GraphQL.php

@@ -500,13 +500,12 @@ protected function getSchemaConfiguration($schema)
      */
     public static function getNormalizedSchemasConfiguration(): array
     {
-        return array_filter(array_map(function ($schema) {
-            try {
+        return array_map(
+            static function ($schema) {
                 return static::getNormalizedSchemaConfiguration($schema);
-            } catch (SchemaNotFound $e) {
-                return null;
-            }
-        }, config('graphql.schemas', [])));
+            },
+            config('graphql.schemas', [])
+        );
     }
 
     /**

tests/TestCase.php

@@ -72,7 +72,6 @@ protected function getEnvironmentSetUp($app): void
         ]);
 
         $app['config']->set('graphql.schemas.class_based', ExampleSchema::class);
-        $app['config']->set('graphql.schemas.invalid_class_based', 'ThisClassDoesntExist');
 
         $app['config']->set('graphql.types', [
             'Example' => ExampleType::class,

tests/Unit/GraphQLTest.php

@@ -97,6 +97,8 @@ public function testSchemaWithWrongName(): void
 
     public function testSchemaWithInvalidClassName(): void
     {
+        $this->app['config']->set('graphql.schemas.invalid_class_based', 'ThisClassDoesntExist');
+
         $this->expectException(SchemaNotFound::class);
         $this->expectExceptionMessage('Schema class ThisClassDoesntExist not found.');
         GraphQL::schema('invalid_class_based');