tests: show that alias alone doens't work as expected

Future fix prepared in #283

Author: mfn

tests/Database/SelectFieldsTest.php

@@ -10,8 +10,10 @@
 use Rebing\GraphQL\Tests\Support\Queries\PostQuery;
 use Rebing\GraphQL\Tests\Support\Types\PostWithModelType;
 use Rebing\GraphQL\Tests\Support\Traits\SqlAssertionTrait;
+use Rebing\GraphQL\Tests\Support\Types\PostWithModelAndAliasType;
 use Rebing\GraphQL\Tests\Support\Queries\PostWithSelectFieldsAndModelQuery;
 use Rebing\GraphQL\Tests\Support\Queries\PostWithSelectFieldsNoModelQuery;
+use Rebing\GraphQL\Tests\Support\Queries\PostWithSelectFieldsAndModelAndAliasQuery;
 
 class SelectFieldsTest extends TestCaseDatabase
 {
@@ -95,6 +97,40 @@ public function testWithSelectFieldsAndModel(): void
         $this->assertEquals($expectedResult, $response->json());
     }
 
+    public function testWithSelectFieldsAndModelAndAlias(): void
+    {
+        $post = factory(Post::class)->create([
+            'title' => 'Description of the post',
+        ]);
+
+        $graphql = <<<GRAQPHQL
+{
+  postWithSelectFieldsAndModelAndAlias(id: $post->id) {
+    id
+    description
+  }
+}
+GRAQPHQL;
+
+        $this->sqlCounterReset();
+
+        $response = $this->call('GET', '/graphql', [
+            'query' => $graphql,
+        ]);
+
+        $this->assertSqlQueries(<<<'SQL'
+select "posts"."id", "posts"."title" from "posts" where "posts"."id" = ? limit 1;
+SQL
+        );
+
+        $this->assertEquals($response->getStatusCode(), 200);
+
+        $result = $response->json();
+
+        $this->assertNull($result['data']['postWithSelectFieldsAndModelAndAlias']);
+        $this->assertSame('Cannot return null for non-nullable field PostWithModelAndAlias.description.', $result['errors'][0]['debugMessage']);
+    }
+
     public function testWithSelectFieldsNoModel(): void
     {
         $post = factory(Post::class)->create([
@@ -142,6 +178,7 @@ protected function getEnvironmentSetUp($app)
             'query' => [
                 PostQuery::class,
                 PostWithSelectFieldsAndModelQuery::class,
+                PostWithSelectFieldsAndModelAndAliasQuery::class,
                 PostWithSelectFieldsNoModelQuery::class,
             ],
         ]);
@@ -151,6 +188,7 @@ protected function getEnvironmentSetUp($app)
         $app['config']->set('graphql.types', [
             PostType::class,
             PostWithModelType::class,
+            PostWithModelAndAliasType::class,
         ]);
 
         $app['config']->set('app.debug', true);

tests/Support/Queries/PostWithSelectFieldsAndModelAndAliasQuery.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rebing\GraphQL\Tests\Support\Queries;
+
+use GraphQL\Type\Definition\Type;
+use Rebing\GraphQL\Support\Query;
+use Rebing\GraphQL\Support\SelectFields;
+use Rebing\GraphQL\Support\Facades\GraphQL;
+use Rebing\GraphQL\Tests\Support\Models\Post;
+
+class PostWithSelectFieldsAndModelAndAliasQuery extends Query
+{
+    protected $attributes = [
+        'name' => 'postWithSelectFieldsAndModelAndAlias',
+    ];
+
+    public function type()
+    {
+        return GraphQL::type('PostWithModelAndAlias');
+    }
+
+    public function args()
+    {
+        return [
+            'id' => [
+                'type' => Type::nonNull(Type::id()),
+            ],
+        ];
+    }
+
+    public function resolve($root, $args, SelectFields $selectFields)
+    {
+        return Post
+            ::select($selectFields->getSelect())
+            ->findOrFail($args['id']);
+    }
+}

tests/Support/Types/PostWithModelAndAliasType.php

@@ -0,0 +1,30 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rebing\GraphQL\Tests\Support\Types;
+
+use GraphQL\Type\Definition\Type;
+use Rebing\GraphQL\Tests\Support\Models\Post;
+use Rebing\GraphQL\Support\Type as GraphQLType;
+
+class PostWithModelAndAliasType extends GraphQLType
+{
+    protected $attributes = [
+        'name' => 'PostWithModelAndAlias',
+        'model' => Post::class,
+    ];
+
+    public function fields()
+    {
+        return [
+            'id' => [
+                'type' => Type::nonNull(Type::id()),
+            ],
+            'description' => [
+                'type' => Type::nonNull(Type::string()),
+                'alias' => 'title',
+            ],
+        ];
+    }
+}