Fix false positives on explicit_acl and explicit_top_level_acl

Fixes #2705

Author: marcelofabri

CHANGELOG.md

@@ -72,6 +72,11 @@
   [Keith Smiley](https://github.com/keith)
   [#2703](https://github.com/realm/SwiftLint/issues/2703)
 
+* Fix false positives on `explicit_acl` and `explicit_top_level_acl` rules when
+  declaring extensions that add protocol conformances with Swift 5.  
+  [Marcelo Fabri](https://github.com/marcelofabri)
+  [#2705](https://github.com/realm/SwiftLint/issues/2705)
+
 ## 0.31.0: Busy Laundromat
 
 #### Breaking

Rules.md

@@ -5763,6 +5763,10 @@ func b() {}
 
 ```
 
+```swift
+extension A: Equatable {}
+```
+
 </details>
 
 
@@ -6064,6 +6068,10 @@ func b() {}
 
 ```
 
+```swift
+extension A: Equatable {}
+```
+
 </details>
 
 

Source/SwiftLintFramework/Rules/Idiomatic/ExplicitACLRule.swift

@@ -47,7 +47,8 @@ public struct ExplicitACLRule: OptInRule, ConfigurationProviderRule, AutomaticTe
             "internal struct C { let d = 5 }\n",
             "public struct C { let d = 5 }\n",
             "func a() {}\n",
-            "internal let a = 0\nfunc b() {}\n"
+            "internal let a = 0\nfunc b() {}\n",
+            "extension A: Equatable {}"
         ]
     )
 
@@ -60,11 +61,20 @@ public struct ExplicitACLRule: OptInRule, ConfigurationProviderRule, AutomaticTe
 
     private func offsetOfElements(from elements: [SourceKittenElement], in file: File,
                                   thatAreNotInRanges ranges: [NSRange]) -> [Int] {
+        let extensionKinds: Set<SwiftDeclarationKind> = [.extension, .extensionClass, .extensionEnum,
+                                                         .extensionProtocol, .extensionStruct]
+
         return elements.compactMap { element in
             guard let typeOffset = element.offset else {
                 return nil
             }
 
+            guard let kind = element.kind.flatMap(SwiftDeclarationKind.init(rawValue:)),
+                case let isConformanceExtension = extensionKinds.contains(kind) && !element.inheritedTypes.isEmpty,
+                !isConformanceExtension else {
+                    return nil
+            }
+
             // find the last "internal" token before the type
             guard let previousInternalByteRange = lastInternalByteRange(before: typeOffset, in: ranges) else {
                 return typeOffset

Source/SwiftLintFramework/Rules/Idiomatic/ExplicitTopLevelACLRule.swift

@@ -25,13 +25,24 @@ public struct ExplicitTopLevelACLRule: OptInRule, ConfigurationProviderRule, Aut
             "final class B {}\n",
             "struct C {}\n",
             "func a() {}\n",
-            "internal let a = 0\nfunc b() {}\n"
+            "internal let a = 0\nfunc b() {}\n",
+            "extension A: Equatable {}"
         ]
     )
 
     public func validate(file: File) -> [StyleViolation] {
+        let extensionKinds: Set<SwiftDeclarationKind> = [.extension, .extensionClass, .extensionEnum,
+                                                         .extensionProtocol, .extensionStruct]
+
         // find all top-level types marked as internal (either explictly or implictly)
         let internalTypesOffsets = file.structure.dictionary.substructure.compactMap { element -> Int? in
+            // ignore extensions that declare protocol conformance
+            guard let kind = element.kind.flatMap(SwiftDeclarationKind.init(rawValue:)),
+                case let isConformanceExtension = extensionKinds.contains(kind) && !element.inheritedTypes.isEmpty,
+                !isConformanceExtension else {
+                    return nil
+            }
+
             if element.accessibility.flatMap(AccessControlLevel.init(identifier:)) == .internal {
                 return element.offset
             }