Skip to content

Theming Components #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayPanoz opened this issue Jan 27, 2025 · 1 comment
Open

Theming Components #58

JayPanoz opened this issue Jan 27, 2025 · 1 comment

Comments

@JayPanoz
Copy link
Contributor

This is a placeholder issue to discuss theming + components. It’s not a priority right now and should be explored at a later date.

Right now UI components are just applying the current’s theme properties when set by the user through CSS Properties (at the :root level). In the future, there could be an option to decouple UI from theming (either disable it entirely for UI Components, or rely on the OS preference (light/dark). Although I've heard about a11y in that context, I’ve not been able to verify it could be useful in that case.

Considering we’re appending CSS Custom Properties through a custom hook (useTheming), it wouldn’t be too difficult to implement alternative options, although the devil is in the details, of course.

@JayPanoz
Copy link
Contributor Author

Note to self: having shared styles (classnames) for all buttons works OK-ish for consistent sizing, etc. but may be an issue when it comes to theming (bg, color, fill, etc.). Maybe a better approach would be to scope them depending on their container (header/footer/sheet/etc.) but that obviously depends on the design of RS Preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant