Skip to content

Commit fbc1144

Browse files
committed
Upgrade Gradle 7.5.1 -> 8.12.1
Also, upgrade plugins: * io.miret.etienne.sass 1.4.1 -> 1.5.2 * com.github.johnrengelman.shadow 7.1.2 -> com.gradleup.shadow 8.3.6
1 parent fe3686f commit fbc1144

7 files changed

+51
-36
lines changed

build.gradle.kts

+9-6
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616

1717
import com.diffplug.gradle.spotless.SpotlessExtension
18-
import com.github.jengelman.gradle.plugins.shadow.ShadowExtension
1918
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
2019
import io.miret.etienne.gradle.sass.CompileSass
2120
import java.util.concurrent.TimeUnit
@@ -41,25 +40,29 @@ configure<JavaApplication> {
4140
mainClass.set("io.projectreactor.Application")
4241
}
4342

44-
configure<ShadowExtension> {
43+
shadow {
4544
version = ""
4645
}
4746

4847
tasks.withType<CompileSass> {
4948
style = compressed
5049
//cannot set sourceDir, but default is $projectDir/src/main/sass - phew!
51-
outputDir = file("$buildDir/resources/main/static/assets/css/")
50+
outputDir = layout.buildDirectory.file("resources/main/static/assets/css/").get().asFile
5251
}
5352

5453
tasks.withType<Jar> {
55-
val compileSass = tasks.getByName("compileSass")
56-
dependsOn(compileSass)
57-
from(file("$buildDir/resources/main/static/assets/css/"))
54+
dependsOn(tasks.compileSass)
55+
from(layout.buildDirectory.file("resources/main/static/assets/css/"))
5856
}
5957

6058
tasks.withType<ShadowJar> {
6159
archiveClassifier.set("")
6260
archiveVersion.set("")
61+
dependsOn(tasks.distTar, tasks.distZip)
62+
}
63+
64+
tasks.withType<JavaCompile> {
65+
dependsOn(tasks.compileSass)
6366
}
6467

6568
configure<SpotlessExtension> {

gradle/libs.versions.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ spring = "org.springframework:spring-core:5.3.39"
1313
thymeleaf = "org.thymeleaf:thymeleaf:3.0.15.RELEASE"
1414

1515
[plugins]
16-
sass = { id = "io.miret.etienne.sass", version = "1.4.1" }
17-
shadow = { id = "com.github.johnrengelman.shadow", version = "7.1.2" }
16+
sass = { id = "io.miret.etienne.sass", version = "1.5.2" }
17+
shadow = { id = "com.gradleup.shadow", version = "8.3.6" }
1818
spotless = { id = "com.diffplug.spotless", version = "6.13.0" }

gradle/wrapper/gradle-wrapper.jar

-16.8 KB
Binary file not shown.
+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12.1-bin.zip
4+
networkTimeout=10000
5+
validateDistributionUrl=true
46
zipStoreBase=GRADLE_USER_HOME
57
zipStorePath=wrapper/dists

gradlew

+24-13
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
# See the License for the specific language governing permissions and
1616
# limitations under the License.
1717
#
18+
# SPDX-License-Identifier: Apache-2.0
19+
#
1820

1921
##############################################################################
2022
#
@@ -55,7 +57,7 @@
5557
# Darwin, MinGW, and NonStop.
5658
#
5759
# (3) This script is generated from the Groovy template
58-
# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
60+
# https://github.com/gradle/gradle/blob/HEAD/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
5961
# within the Gradle project.
6062
#
6163
# You can find Gradle at https://github.com/gradle/gradle/.
@@ -80,13 +82,11 @@ do
8082
esac
8183
done
8284

83-
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
84-
85-
APP_NAME="Gradle"
85+
# This is normally unused
86+
# shellcheck disable=SC2034
8687
APP_BASE_NAME=${0##*/}
87-
88-
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
89-
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
88+
# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036)
89+
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) || exit
9090

9191
# Use the maximum available, or set MAX_FD != -1 to use that value.
9292
MAX_FD=maximum
@@ -133,22 +133,29 @@ location of your Java installation."
133133
fi
134134
else
135135
JAVACMD=java
136-
which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
136+
if ! command -v java >/dev/null 2>&1
137+
then
138+
die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
137139
138140
Please set the JAVA_HOME variable in your environment to match the
139141
location of your Java installation."
142+
fi
140143
fi
141144

142145
# Increase the maximum file descriptors if we can.
143146
if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
144147
case $MAX_FD in #(
145148
max*)
149+
# In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
150+
# shellcheck disable=SC2039,SC3045
146151
MAX_FD=$( ulimit -H -n ) ||
147152
warn "Could not query maximum file descriptor limit"
148153
esac
149154
case $MAX_FD in #(
150155
'' | soft) :;; #(
151156
*)
157+
# In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
158+
# shellcheck disable=SC2039,SC3045
152159
ulimit -n "$MAX_FD" ||
153160
warn "Could not set maximum file descriptor limit to $MAX_FD"
154161
esac
@@ -193,11 +200,15 @@ if "$cygwin" || "$msys" ; then
193200
done
194201
fi
195202

196-
# Collect all arguments for the java command;
197-
# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
198-
# shell script including quotes and variable substitutions, so put them in
199-
# double quotes to make sure that they get re-expanded; and
200-
# * put everything else in single quotes, so that it's not re-expanded.
203+
204+
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
205+
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
206+
207+
# Collect all arguments for the java command:
208+
# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments,
209+
# and any embedded shellness will be escaped.
210+
# * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be
211+
# treated as '${Hostname}' itself on the command line.
201212

202213
set -- \
203214
"-Dorg.gradle.appname=$APP_BASE_NAME" \

gradlew.bat

+13-10
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
@rem See the License for the specific language governing permissions and
1414
@rem limitations under the License.
1515
@rem
16+
@rem SPDX-License-Identifier: Apache-2.0
17+
@rem
1618

1719
@if "%DEBUG%"=="" @echo off
1820
@rem ##########################################################################
@@ -26,6 +28,7 @@ if "%OS%"=="Windows_NT" setlocal
2628

2729
set DIRNAME=%~dp0
2830
if "%DIRNAME%"=="" set DIRNAME=.
31+
@rem This is normally unused
2932
set APP_BASE_NAME=%~n0
3033
set APP_HOME=%DIRNAME%
3134

@@ -42,11 +45,11 @@ set JAVA_EXE=java.exe
4245
%JAVA_EXE% -version >NUL 2>&1
4346
if %ERRORLEVEL% equ 0 goto execute
4447

45-
echo.
46-
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
47-
echo.
48-
echo Please set the JAVA_HOME variable in your environment to match the
49-
echo location of your Java installation.
48+
echo. 1>&2
49+
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2
50+
echo. 1>&2
51+
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
52+
echo location of your Java installation. 1>&2
5053

5154
goto fail
5255

@@ -56,11 +59,11 @@ set JAVA_EXE=%JAVA_HOME%/bin/java.exe
5659

5760
if exist "%JAVA_EXE%" goto execute
5861

59-
echo.
60-
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
61-
echo.
62-
echo Please set the JAVA_HOME variable in your environment to match the
63-
echo location of your Java installation.
62+
echo. 1>&2
63+
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2
64+
echo. 1>&2
65+
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
66+
echo location of your Java installation. 1>&2
6467

6568
goto fail
6669

settings.gradle

-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,2 @@
11
rootProject.name = 'projectreactor-home'
22
rootProject.buildFileName = 'build.gradle.kts'
3-
4-
//libs catalog is declared in ./gradle/libs.versions.toml
5-
//TODO remove once Version Catalogs are stabilized.
6-
enableFeaturePreview("VERSION_CATALOGS")

0 commit comments

Comments
 (0)