[core] Place plasma bazel targets into separate directories #52016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
reviewed
Apr 5, 2025
| @@ -219,3 +219,9 @@ filter_files_with_suffix = rule( | |||
| "suffix": attr.string(), | |||
| }, | |||
| ) | |||
|
|
|||
| FLATC_ARGS = [ | |||
dentiny
reviewed
Apr 5, 2025
| load("//bazel:ray.bzl", "COPTS", "FLATC_ARGS", "ray_cc_library", "ray_cc_test") | ||
|
|
||
| # TODO(mehrdadn): (How to) support dynamic linking? | ||
| PROPAGATED_WINDOWS_DEFINES = ["ARROW_STATIC"] |
There was a problem hiding this comment.
nit: starlark mostly follows python grammar, so prefer to use _ prefix to indicate private variables.
dentiny
reviewed
Apr 5, 2025
| out_prefix = "", | ||
| ) | ||
|
|
||
| ray_cc_test( |
There was a problem hiding this comment.
Just FYI: I don't have a strong preference here, but generally BUILD file lives under the same directory as the source file (which is also the purpose for this issue :) )
There was a problem hiding this comment.
Sure! I checked the /src/ray/common and it put the tests at seperate BUILD file.
Ziy1-Tan
force-pushed
the
subbazel_plasma
branch
2 times, most recently
from
2d454c7 to
ab3ce40
Compare
|
@Ziy1-Tan Just FYI, as far as I'm aware of, currently main branch is broken and tests pretty flaky; so you don't need to take too much time debugging and merging main :) |
Ziy1-Tan
force-pushed
the
subbazel_plasma
branch
from
ab3ce40 to
3bd5670
Compare
dentiny
reviewed
Apr 7, 2025
| @@ -18,8 +18,6 @@ | |||
| #include <utility> | |||
| #include <vector> | |||
|
|
|||
| #include "absl/random/random.h" | |||
| #include "absl/strings/str_format.h" | |||
|
Just enabled ci for you, ping me when it's passed, thank you! |
Ziy1-Tan
force-pushed
the
subbazel_plasma
branch
2 times, most recently
from
3d668ff to
7207c64
Compare
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Signed-off-by: Ziy1-Tan <[email protected]>
Ziy1-Tan
force-pushed
the
subbazel_plasma
branch
from
7207c64 to
c7f737b
Compare
|
Hey, @dentiny . The CI is good now:) |
han-steve
pushed a commit
to han-steve/ray
that referenced
this pull request
Apr 11, 2025
…ect#52016) Closes ray-project#52010 --------- Signed-off-by: Ziy1-Tan <[email protected]> Signed-off-by: Steve Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #52010
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.