[core] Place scheduler bazel targets into separate directories #52006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziy1-Tan <[email protected]>
Ziy1-Tan
force-pushed
the
subbazel_scheduler
branch
from
b8d53aa to
5a9790f
Compare
dentiny
reviewed
Apr 5, 2025
| @@ -14,14 +14,12 @@ | |||
|
|
|||
| #include "ray/raylet/scheduling/cluster_resource_manager.h" | |||
|
|
|||
| #include <boost/algorithm/string.hpp> | |||
There was a problem hiding this comment.
Thanks for cleaning up the dependency!
Signed-off-by: Ziy1-Tan <[email protected]>
dentiny
approved these changes
Apr 5, 2025
| "//src/ray/common:id", | ||
| "//src/ray/common:network", |
There was a problem hiding this comment.
(just for my own curiosity) how did you get these dependencies sorted in alphabetical order?
Did you use linter in your IDE?
There was a problem hiding this comment.
Yes! Use buildifier and vscode-bazel together, deps will be sorted in order each time you save.
pavelkushtia
pushed a commit
to pavelkushtia/ray
that referenced
this pull request
Apr 6, 2025
…roject#52006) Signed-off-by: Ziy1-Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #51987
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.