Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Skip writing zero sized blocks to bigquery #51919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[data] Skip writing zero sized blocks to bigquery #51919

wants to merge 1 commit into from

Conversation

FredrikNoren
Copy link

@FredrikNoren FredrikNoren commented Apr 2, 2025 •
edited
Loading

Why are these changes needed?

Zero-sized blocks writes crashes the bigquery writer as there's no schema for them (see issue).

Related issue number

Closes #51892

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@FredrikNoren FredrikNoren requested a review from a team as a code owner April 2, 2025 12:30
@FredrikNoren FredrikNoren mentioned this pull request Apr 2, 2025
Open
@jcotant1 jcotant1 added the data Ray Data-related issues label Apr 2, 2025
@richardliaw richardliaw changed the title Skip writing zero sized blocks to bigquery [data] Skip writing zero sized blocks to bigquery Apr 2, 2025
@richardliaw
Copy link
Contributor

Hi @FredrikNoren -- Could you also add a test and also fix the DCO?

Thanks!

@richardliaw richardliaw self-assigned this Apr 2, 2025
@FredrikNoren FredrikNoren force-pushed the bigquery-zero-write branch from 05e7a0a to 4f99e76 Compare April 2, 2025 19:13
@FredrikNoren FredrikNoren force-pushed the bigquery-zero-write branch from 4f99e76 to fc9867d Compare April 2, 2025 19:15
@richardliaw richardliaw added the go add ONLY when ready to merge, run all tests label Apr 2, 2025
@richardliaw
Copy link
Contributor

Hi @FredrikNoren -- thanks for fixing DCO! just to confirm, could you also add a quick test for this behavior?

@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label Apr 4, 2025
@richardliaw richardliaw added the @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. label Apr 10, 2025
@richardliaw
Copy link
Contributor

Hi @FredrikNoren, could you also fix the lint errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@richardliaw richardliaw

Labels
community-contribution Contributed by the community data Ray Data-related issues @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data] Zero-sized blocks crashes write_bigquery
4 participants
@FredrikNoren @richardliaw @hainesmichaelc @jcotant1