Skip to content

Commit 23d9180

Browse files
committed
Revert "fbdev: Allow client to request a particular /dev/fbN node"
This reverts commit e8402a6.
1 parent 274049e commit 23d9180

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

drivers/video/fbdev/core/fbmem.c

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ struct class *fb_class;
3131
DEFINE_MUTEX(registration_lock);
3232
struct fb_info *registered_fb[FB_MAX] __read_mostly;
3333
int num_registered_fb __read_mostly;
34-
int min_dynamic_fb __read_mostly;
3534
#define for_each_registered_fb(i) \
3635
for (i = 0; i < FB_MAX; i++) \
3736
if (!registered_fb[i]) {} else
@@ -399,12 +398,10 @@ static int do_register_framebuffer(struct fb_info *fb_info)
399398
return -ENXIO;
400399

401400
num_registered_fb++;
402-
if (!fb_info->custom_fb_num || fb_info->node >= FB_MAX || registered_fb[fb_info->node]) {
403-
for (i = min_dynamic_fb ; i < FB_MAX; i++)
404-
if (!registered_fb[i])
405-
break;
406-
fb_info->node = i;
407-
}
401+
for (i = 0 ; i < FB_MAX; i++)
402+
if (!registered_fb[i])
403+
break;
404+
fb_info->node = i;
408405
refcount_set(&fb_info->count, 1);
409406
mutex_init(&fb_info->lock);
410407
mutex_init(&fb_info->mm_lock);
@@ -439,7 +436,7 @@ static int do_register_framebuffer(struct fb_info *fb_info)
439436

440437
fb_var_to_videomode(&mode, &fb_info->var);
441438
fb_add_videomode(&mode, &fb_info->modelist);
442-
registered_fb[fb_info->node] = fb_info;
439+
registered_fb[i] = fb_info;
443440

444441
#ifdef CONFIG_GUMSTIX_AM200EPD
445442
{
@@ -500,12 +497,6 @@ static void do_unregister_framebuffer(struct fb_info *fb_info)
500497
put_fb_info(fb_info);
501498
}
502499

503-
void fb_set_lowest_dynamic_fb(int min_fb_dev)
504-
{
505-
min_dynamic_fb = min_fb_dev;
506-
}
507-
EXPORT_SYMBOL(fb_set_lowest_dynamic_fb);
508-
509500
/**
510501
* register_framebuffer - registers a frame buffer device
511502
* @fb_info: frame buffer info structure

include/linux/fb.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,6 @@ struct fb_info {
511511

512512
bool skip_vt_switch; /* no VT switch on suspend/resume required */
513513
bool skip_panic; /* Do not write to the fb after a panic */
514-
bool custom_fb_num; /* Use value in node as the preferred node number */
515514
};
516515

517516
/* This will go away
@@ -601,7 +600,6 @@ extern ssize_t fb_sys_write(struct fb_info *info, const char __user *buf,
601600
.fb_imageblit = sys_imageblit
602601

603602
/* fbmem.c */
604-
extern void fb_set_lowest_dynamic_fb(int min_fb_dev);
605603
extern int register_framebuffer(struct fb_info *fb_info);
606604
extern void unregister_framebuffer(struct fb_info *fb_info);
607605
extern int devm_register_framebuffer(struct device *dev, struct fb_info *fb_info);

0 commit comments

Comments
 (0)