Skip to content

Commit 1ceca9a

Browse files
mripardpopcornmix
authored andcommitted
drm/vc4: tests: Drop drm parameter for vc4_find_crtc_for_encoder
The DRM device pointer and the DRM encoder pointer are redundant, since the latter is attached to the former and we can just follow the drm_encoder->dev pointer. Let's remove the drm_device pointer argument. Signed-off-by: Maxime Ripard <[email protected]>
1 parent d15beab commit 1ceca9a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

drivers/gpu/drm/vc4/tests/vc4_mock.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
static inline
99
struct drm_crtc *vc4_find_crtc_for_encoder(struct kunit *test,
10-
struct drm_device *drm,
1110
struct drm_encoder *encoder)
1211
{
12+
struct drm_device *drm = encoder->dev;
1313
struct drm_crtc *crtc;
1414

1515
KUNIT_ASSERT_EQ(test, hweight32(encoder->possible_crtcs), 1);

drivers/gpu/drm/vc4/tests/vc4_mock_output.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ vc4_mock_atomic_add_output(struct kunit *test,
7979
if (!encoder)
8080
return -ENODEV;
8181

82-
crtc = vc4_find_crtc_for_encoder(test, drm, encoder);
82+
crtc = vc4_find_crtc_for_encoder(test, encoder);
8383
if (!crtc)
8484
return -ENODEV;
8585

@@ -123,7 +123,7 @@ int vc4_mock_atomic_del_output(struct kunit *test,
123123
if (!encoder)
124124
return -ENODEV;
125125

126-
crtc = vc4_find_crtc_for_encoder(test, drm, encoder);
126+
crtc = vc4_find_crtc_for_encoder(test, encoder);
127127
if (!crtc)
128128
return -ENODEV;
129129

drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ get_vc4_crtc_state_for_encoder(struct kunit *test,
145145
encoder = vc4_find_encoder_by_type(drm, type);
146146
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, encoder);
147147

148-
crtc = vc4_find_crtc_for_encoder(test, drm, encoder);
148+
crtc = vc4_find_crtc_for_encoder(test, encoder);
149149
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc);
150150

151151
new_crtc_state = drm_atomic_get_new_crtc_state(state, crtc);

0 commit comments

Comments
 (0)