Skip to content

Commit 9396bbb

Browse files
authored
use wildcards in auditwheel exclusions (#4877)
Contributes to rapidsai/build-planning#137 Follow-up to #4804 Wheel builds here currently list out some shared library to exclude in `auditwheel repair`, which they pick up transitively via linking to `libraft`. https://github.com/rapidsai/cugraph/blob/a9c923bb3f4a6a6f5a9d46337adc65d969717567/ci/build_wheel.sh#L42-L49 The version components of those library names can change when those libraries have ABI breakages, for example across CUDA major version boundaries. This proposes replacing specific versions with wildcards, to exclude *all* versions of those libraries. ## Notes for Reviewers This is especially relevant given this: rapidsai/raft#2548 For example, the latest `nvidia-cublas-cu11` has `libcublas.so.11` while `nvidia-cublas-cu12` has `libcublas.so.12`. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #4877
1 parent a9c923b commit 9396bbb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

ci/build_wheel.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ EXCLUDE_ARGS=(
4040
# 'libraft' wheels are responsible for carrying a runtime dependency on
4141
# these based on RAFT's needs.
4242
EXCLUDE_ARGS+=(
43-
--exclude "libcublas.so.12"
44-
--exclude "libcublasLt.so.12"
45-
--exclude "libcurand.so.10"
46-
--exclude "libcusolver.so.11"
47-
--exclude "libcusparse.so.12"
48-
--exclude "libnvJitLink.so.12"
43+
--exclude "libcublas.so.*"
44+
--exclude "libcublasLt.so.*"
45+
--exclude "libcurand.so.*"
46+
--exclude "libcusolver.so.*"
47+
--exclude "libcusparse.so.*"
48+
--exclude "libnvJitLink.so.*"
4949
)
5050

5151
if [[ "${package_dir}" != "python/libcugraph" ]]; then

0 commit comments

Comments
 (0)