Skip to content

PHP 8.4 Deprecation warning #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PNardman opened this issue Feb 18, 2025 · 2 comments · May be fixed by #590
Open

PHP 8.4 Deprecation warning #587

PNardman opened this issue Feb 18, 2025 · 2 comments · May be fixed by #590
Labels

Comments

@PNardman
Copy link

Description

Implicitly nullable values are deprecated in php 8.4 and lead to deprecation warnings in 8.4.

Steps to reproduce

SystemDceSecurityProvider::L177 still calls str_getcsv without the escape parameter, that is deprecated in php 8.4.

Expected behavior

No deprecation warnings under 8.4

Environment details

  • version of this package: "4.7.6"
  • PHP version: 8.4
  • OS: Windows
@PNardman PNardman added the bug label Feb 18, 2025
@PNardman PNardman changed the title SystemDceSecurityProvider PHP 8.4 Deprecation warning Feb 18, 2025
@Chris53897
Copy link
Contributor

@PNardman Would you be up for a PR?

@PNardman
Copy link
Author

PNardman commented Mar 4, 2025

@PNardman Would you be up for a PR?

Will do!

@PNardman PNardman linked a pull request Mar 5, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants