fix: Make pre-submits blocking (slsa-framework#549)

* update

* update

Author: laurentsimon

.github/workflows/pre-submit.e2e.generic.default.yml

@@ -27,6 +27,7 @@ jobs:
     name: verify generic provenance
     runs-on: ubuntu-latest
     needs: [build]
+    if: ${{ always() }}
     steps:
       - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2
       - uses: actions/download-artifact@fb598a63ae348fa914e94cd0ff38f362e927b741 # tag=v3.0.0

.github/workflows/pre-submit.e2e.go.config-ldflags-main-dir.yml

@@ -46,6 +46,7 @@ jobs:
     name: verify go provenance
     runs-on: ubuntu-latest
     needs: [build]
+    if: ${{ always() }}
     steps:
       - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2
       - uses: actions/download-artifact@fb598a63ae348fa914e94cd0ff38f362e927b741 # tag=v3.0.0

.github/workflows/pre-submit.units.yml

@@ -17,6 +17,7 @@ jobs:
     # other pre-submits.
     name: unit tests
     runs-on: ubuntu-latest
+    if: ${{ always() }}
     steps:
       - name: Checkout
         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3.0.2
@@ -59,7 +60,9 @@ jobs:
           go build -mod=vendor ./internal/builders/generic
 
   check-verifier:
+    name: verify slsa-verifier is latest
     runs-on: ubuntu-latest
+    if: ${{ always() }}
     steps:
       - name: Checkout
         uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # v2.3.4

internal/builders/generic/attest.go

@@ -147,7 +147,7 @@ func pathIsUnderCurrentDirectory(path string) error {
 
 	if !strings.HasPrefix(p, wd+"/") &&
 		wd != p {
-		return errors.Errorf(&errInvalidPath{}, "path: %q", path)
+		return errors.Errorf(&errInvalidPath{}, "invalid path: %q", path)
 	}
 
 	return nil