read csv unstrictly by default

Author: raine

README.md

@@ -362,7 +362,6 @@ Usage: ramda [options] [function] ...
       --csv-delimiter  custom csv delimiter character
       --js             use javascript instead of livescript
       --import         import a module from npm
-  -u, --csv-unstrict   use with input type csv/tsv and headers to ignore column mismatch
   -C, --configure      edit config in $EDITOR
   -v, --verbose        print debugging information (use -vv for even more)
       --version        print version
@@ -513,32 +512,6 @@ EOF
 ]
 ```
 
-##### `-u, --csv-unstrict`
-
-Ignore CSV/TSV column mismatch, useful with some POSIX commands.
-
-__Examples__
-
-```sh
-$ ps aux | sed -E 's/ +/,/g'
-USER,PID,%CPU,%MEM,VSZ,RSS,TTY,STAT,START,TIME,COMMAND
-root,1,0.0,0.0,8324,152,?,Ss,May28,0:00,/init
-root,3,0.0,0.0,8332,156,tty1,Ss,May28,0:00,/init
-pi,17039,0.0,0.0,17380,1940,tty3,R,18:15,0:00,ps,aux
-pi,17040,0.0,0.0,14860,1160,tty3,S,18:15,0:00,sed,-E,s/,+/,/g
-```
-
-```sh
-$ ps aux | sed -E 's/ +/,/g' | ramda -i csv -p 'countBy (.USER)'
-Error: Unexpected Error: column header mismatch expected: 11 columns got: 12
-```
-
-```sh
-$ ps aux | sed -E 's/ +/,/g' | ramda -i csv -u -p 'countBy (.USER)'
-{ root: 2, pi: 2 }
-```
-
-
 #### `-o, --output-type`
 
 Instead of JSON, format output as one of: `pretty`, `raw`, `csv`, `tsv`, `table`.

src/argv.ls

@@ -30,7 +30,6 @@ HELP =
           --csv-delimiter  custom csv delimiter character
           --js             use javascript instead of livescript
           --import         import a module from npm
-      -u, --csv-unstrict   use with inupt type csv/tsv and headers to ignore column mismatch
       -C, --configure      edit config in $EDITOR
       -v, --verbose        print debugging information (use -vv for even more)
           --version        print version
@@ -76,7 +75,7 @@ export parse = (argv) ->
     argv = map (wrap-number-lookup << wrap-function), argv.slice 2
     opts = camelize minimist argv,
         string: <[ file input-type output-type json-path csv-delimiter ]>
-        boolean: <[ compact slurp unslurp pretty verbose version raw-input raw-output configure no-stdin js transduce headers interactive csv-unstrict ]>
+        boolean: <[ compact slurp unslurp pretty verbose version raw-input raw-output configure no-stdin js transduce headers interactive ]>
         alias: parse-aliases HELP
         default: {
             +stdin,

src/stream.ls

@@ -59,10 +59,14 @@ blank-obj-stream = ->
     PassThrough {+object-mode}
         ..end {}
 
-csv-opts = (type, delimiter, headers, unstrict = false) ->
-    opts = { headers, include-end-row-delimiter: true, delimiter }
-    if headers and unstrict
-        opts <<< { +discardUnmappedColumns, -strictColumnHandling }
+csv-opts = (type, delimiter, headers, unstrict = true) ->
+    opts = {
+      headers,
+      delimiter,
+      +include-end-row-delimiter,
+      +discard-unmapped-columns,
+      -strict-column-handling
+    }
     switch type
     | \csv => opts
     | \tsv => opts <<< delimiter: '\t'
@@ -100,7 +104,7 @@ opts-to-output-stream = (opts) ->
 opts-to-input-parser-stream = (opts) ->
     switch opts.input-type
     | \raw          => split2!
-    | <[ csv tsv ]> => (require 'fast-csv') csv-opts opts.input-type, opts.csv-delimiter, opts.headers, opts.csv-unstrict
+    | <[ csv tsv ]> => (require 'fast-csv') csv-opts opts.input-type, opts.csv-delimiter, opts.headers
     | otherwise     => JSONStream.parse opts.json-path
 
 make-stdin-parser = (on-error, opts, stdin) ->

test/unit/argv.ls

@@ -99,11 +99,3 @@ describe 'argv.parse' (,) ->
     it 'reads ".0" as string' ->
          args = argv.parse [,, '.0', '.foo']
          args._.0 `eq` '(.0)'
-
-    describe '-u, --unstrict', (,) ->
-        it 'defaults to false' ->
-            parse '' .csv-unstrict `eq` false
-        it 'set csv-unstrict to true, short' ->
-            parse '-u' .csv-unstrict `eq` true
-        it 'set csv-unstrict to true' ->
-            parse '--csv-unstrict' .csv-unstrict `eq` true

test/unit/basic.ls

@@ -337,39 +337,23 @@ describe '--input-type csv' (,) ->
         output `strip-eq` expected
         done!
 
-    it 'reads csv with headers unstrict' (done) ->
-        args = <[ -i csv -u identity ]>
+    it 'with headers, ignores extra columns that don\'t have a header' (done) ->
+        args = <[ -i csv identity ]>
         input = """
         name,code
         Afghanistan,AF,XX
         Åland Islands,AX
-        Albania
+        Albania,AL
         """
         expected = """
         [ { "name": "Afghanistan", "code": "AF" },
           { "name": "Åland Islands", "code": "AX" },
-          { "name": "Albania", "code": "" } ]
+          { "name": "Albania", "code": "AL" } ]
         """
         output <-! run-main args, input
         output `strip-eq` expected
         done!
 
-    describe '--input-type csv/tsv default strict' (,) ->
-        stub-process-exit!
-        it 'strict mode, header mismatch' (done) ->
-            args = <[ -i csv ]>
-            input = """
-            Afghanistan,AF
-            Åland Islands,AX,XX
-            Albania,AL
-            """
-            expected = """
-            Error: Unexpected Error: column header mismatch expected: 2 columns got: 3\n
-            """
-            output, errput <-! run-main args, input
-            errput `eq` expected
-            done!
-
 describe '--input-type tsv' (,) ->
     it 'reads tsv with headers into a list of objects' (done) ->
         args  = <[ -i tsv identity ]>