Skip to content

Commit c09131c

Browse files
committed
Do not respond to http requests asking for a file://
Based on CVE-2018-3760 when the Sprockets server is accidentally being used in production, an attacker can pass in a specifically crafted url that will allow them access to view every file on the system. If the file hit contains a compilable extension such as `.erb` then the code in that file will be executed. A Rails app will be using the Sprockets file server in production if they have accidentally configured their app to: ```ruby config.assets.compile = true # Your app is vulnerable ``` It is highly recommended to not use the Sprockets server in production and to instead precompile assets to disk and serve them through a server such as Nginx or via the static file middleware that ships with rails `config.public_file_server.enabled = true`. This patch mitigates the issue, but explicitly disallowing any requests to uri resources via the server.
1 parent ef678cc commit c09131c

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/sprockets/server.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def forbidden_request?(path)
114114
#
115115
# http://example.org/assets/../../../etc/passwd
116116
#
117-
path.include?("..") || absolute_path?(path)
117+
path.include?("..") || absolute_path?(path) || path.include?("://")
118118
end
119119

120120
def head_request?(env)

test/test_server.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,13 @@ def app
286286
assert_equal "", last_response.body
287287
end
288288

289+
test "illegal access of a file asset" do
290+
absolute_path = fixture_path("server/app/javascripts")
291+
292+
get "assets/file:%2f%2f//#{absolute_path}/foo.js"
293+
assert_equal 403, last_response.status
294+
end
295+
289296
test "add new source to tree" do
290297
filename = fixture_path("server/app/javascripts/baz.js")
291298

0 commit comments

Comments
 (0)