Skip to content

Commit 93a51f9

Browse files
committed
Ruff enable F, W, I and run autofix
1 parent 26d5fe8 commit 93a51f9

File tree

78 files changed

+164
-173
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+164
-173
lines changed

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
line-length = 120
33
# Rule descriptions: https://docs.astral.sh/ruff/rules/
44
# TODO enable more linter
5-
#lint.select = ["I", "E", "B", "F", "W", "N", "C4", "C90", "ARG", "PL", "RUF", "UP"]
5+
#lint.select = ["E", "B", "N", "C4", "C90", "ARG", "PL", "RUF", "UP"]
6+
lint.select = ["F", "W", "I"]
67

78
[tool.ruff.lint.per-file-ignores]
89
# Example ignore for all tests (Magic value used in comparison)

radish/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
__BUGTRACK_URL__ = "https://github.com/radish-bdd/radish/issues"
99

1010
# export some functions for users
11-
from .terrain import world, pick
12-
from .hookregistry import before, after
13-
from .stepregistry import step, given, when, then, steps
14-
from .customtyperegistry import custom_type, register_custom_type, TypeBuilder
15-
from .extensionregistry import extension
11+
from .customtyperegistry import TypeBuilder, custom_type, register_custom_type
1612
from .exceptions import ValidationError
13+
from .extensionregistry import extension
14+
from .hookregistry import after, before
15+
from .stepregistry import given, step, steps, then, when
16+
from .terrain import pick, world

radish/core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
Providing radish core functionality.
33
"""
44

5-
from threading import Lock
65
from collections import OrderedDict
6+
from threading import Lock
77

88
from .parser import FeatureParser
99

radish/customtyperegistry.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
This module provides the Argument-Expression Registry
33
"""
44

5-
from singleton import singleton
6-
75
# Keep for backwards compat:
86
from parse_type import TypeBuilder # noqa: F401
7+
from singleton import singleton
98

109
from .exceptions import RadishError
1110

radish/errororacle.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@
88
import colorful
99

1010
from .exceptions import (
11-
RadishError,
1211
HookError,
12+
RadishError,
1313
)
1414
from .utils import Failure, console_write
1515

16-
1716
__RADISH_DOC__ = "https://github.com/radish-bdd/radish"
1817

1918

radish/exceptions.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from .terrain import world
22

3-
43
__DOCS__ = "https://github.com/radish-bdd/radish"
54

65

radish/extensions/bdd_xml_writer.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@
22
This module provides a hook which generates a BDD XML result file at the end of the run.
33
"""
44

5-
from os import getlogin
5+
import re
6+
from datetime import timedelta
67
from getpass import getuser
8+
from os import getlogin
79
from socket import gethostname
8-
from datetime import timedelta
9-
import re
1010

11-
from radish.terrain import world
12-
from radish.hookregistry import after
11+
import radish.utils as utils
1312
from radish.exceptions import RadishError
14-
from radish.scenariooutline import ScenarioOutline
13+
from radish.extensionregistry import extension
14+
from radish.hookregistry import after
1515
from radish.scenarioloop import ScenarioLoop
16+
from radish.scenariooutline import ScenarioOutline
1617
from radish.stepmodel import Step
17-
from radish.extensionregistry import extension
18-
import radish.utils as utils
18+
from radish.terrain import world
1919

2020

2121
@extension

radish/extensions/codecoverage.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,14 @@
33
coverage measurements.
44
"""
55

6-
import sys
76
import re
8-
7+
import sys
98
from io import StringIO
109

10+
from radish.exceptions import RadishError
1111
from radish.extensionregistry import extension
12-
from radish.hookregistry import before, after
12+
from radish.hookregistry import after, before
1313
from radish.terrain import world
14-
from radish.exceptions import RadishError
1514

1615

1716
@extension

radish/extensions/cucumber_json_writer.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
This module provides a hook which generates a cucumber json result file at the end of the run.
33
"""
44

5-
from datetime import timedelta, datetime, timezone
65
import json
6+
from datetime import datetime, timedelta, timezone
77

8-
from radish.terrain import world
9-
from radish.hookregistry import after
108
from radish.exceptions import RadishError
11-
from radish.scenariooutline import ScenarioOutline
9+
from radish.extensionregistry import extension
10+
from radish.hookregistry import after
1211
from radish.scenarioloop import ScenarioLoop
12+
from radish.scenariooutline import ScenarioOutline
1313
from radish.stepmodel import Step
14-
from radish.extensionregistry import extension
14+
from radish.terrain import world
1515

1616

1717
@extension

radish/extensions/endreport_writer.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@
77
import colorful
88
import humanize
99

10+
from radish.extensionregistry import extension
1011
from radish.hookregistry import after
11-
from radish.stepmodel import Step
12-
from radish.utils import console_write as write, make_unique_obj_list, get_func_code
13-
from radish.scenariooutline import ScenarioOutline
1412
from radish.scenarioloop import ScenarioLoop
15-
from radish.extensionregistry import extension
16-
from radish.terrain import world
13+
from radish.scenariooutline import ScenarioOutline
14+
from radish.stepmodel import Step
1715
from radish.stepregistry import StepRegistry
16+
from radish.terrain import world
17+
from radish.utils import console_write as write
18+
from radish.utils import get_func_code, make_unique_obj_list
1819

1920

2021
@extension

radish/extensions/failure_debugger.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
This module provides an extension which starts a debugger when a step fails
33
"""
44

5+
import radish.utils as utils
6+
from radish.extensionregistry import extension
57
from radish.hookregistry import after
68
from radish.stepmodel import Step
7-
from radish.extensionregistry import extension
8-
import radish.utils as utils
99

1010

1111
@extension

radish/extensions/failure_inspector.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
This module provides an extension which starts a python shell after a step failed
33
"""
44

5-
from radish.hookregistry import after
6-
from radish.stepmodel import Step
75
from radish.exceptions import RadishError
86
from radish.extensionregistry import extension
7+
from radish.hookregistry import after
8+
from radish.stepmodel import Step
99

1010

1111
@extension

radish/extensions/formatters/dots.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33
"""
44

55
import sys
6+
67
import colorful as cf
78

8-
from radish.terrain import world
9-
from radish.hookregistry import before, after
10-
from radish.scenariooutline import ScenarioOutline
9+
from radish.extensionregistry import extension
10+
from radish.hookregistry import after, before
1111
from radish.scenarioloop import ScenarioLoop
12+
from radish.scenariooutline import ScenarioOutline
1213
from radish.stepmodel import Step
13-
from radish.extensionregistry import extension
14+
from radish.terrain import world
1415

1516

1617
@extension

radish/extensions/formatters/gherkin.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,16 @@
44

55
import os
66
import re
7+
78
import colorful
89

9-
from radish.terrain import world
10-
from radish.hookregistry import before, after
10+
from radish.extensionregistry import extension
1111
from radish.feature import Feature
12-
from radish.scenariooutline import ScenarioOutline
12+
from radish.hookregistry import after, before
1313
from radish.scenarioloop import ScenarioLoop
14+
from radish.scenariooutline import ScenarioOutline
1415
from radish.stepmodel import Step
15-
from radish.extensionregistry import extension
16+
from radish.terrain import world
1617
from radish.utils import console_write as write
1718

1819

radish/extensions/junit_xml_writer.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
This module provides a hook which generates a JUnit XML result file at the end of the run.
33
"""
44

5-
from datetime import timedelta
65
import re
6+
from datetime import timedelta
77

8-
from radish.terrain import world
9-
from radish.hookregistry import after
8+
import radish.utils as utils
109
from radish.exceptions import RadishError
11-
from radish.scenariooutline import ScenarioOutline
10+
from radish.extensionregistry import extension
11+
from radish.hookregistry import after
1212
from radish.scenarioloop import ScenarioLoop
13+
from radish.scenariooutline import ScenarioOutline
1314
from radish.stepmodel import Step
14-
from radish.extensionregistry import extension
15-
import radish.utils as utils
15+
from radish.terrain import world
1616

1717

1818
@extension

radish/extensions/syslog_writer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
import os
66
import sys
77

8-
from radish.terrain import world
9-
from radish.feature import Feature
10-
from radish.hookregistry import before, after
118
from radish.extensionregistry import extension
9+
from radish.feature import Feature
10+
from radish.hookregistry import after, before
11+
from radish.terrain import world
1212

1313

1414
@extension

radish/extensions/time_recorder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
from datetime import datetime, timezone
66

7-
from radish.hookregistry import after, before
87
from radish.extensionregistry import extension
8+
from radish.hookregistry import after, before
99

1010
__REQUIRED__ = True
1111

radish/extensions/user_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66

77
import re
88

9-
from radish.terrain import world
109
from radish.exceptions import RadishError
1110
from radish.extensionregistry import extension
11+
from radish.terrain import world
1212

1313

1414
@extension

radish/feature.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"""
44

55
from .model import Model
6-
from .scenariooutline import ScenarioOutline
76
from .scenarioloop import ScenarioLoop
7+
from .scenariooutline import ScenarioOutline
88
from .stepmodel import Step
99
from .terrain import world
1010

radish/hookregistry.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@
22
This module provides a registry for all hooks
33
"""
44

5+
import tagexpressions
56
from singleton import singleton
67

78
from . import utils
89
from .exceptions import HookError
910

10-
import tagexpressions
11-
1211

1312
@singleton()
1413
class HookRegistry(object):

radish/loader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
This module contains a class to load the step and terrain files
33
"""
44

5-
import os
65
import fnmatch
6+
import os
77

88

99
def load_modules(location):

radish/main.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,21 @@
33
import uuid
44
import warnings
55

6-
from docopt import docopt
76
import colorful
87
import tagexpressions
8+
from docopt import docopt
99

10-
from . import __VERSION__
11-
from .core import Core
12-
from .core import Configuration
10+
from . import __VERSION__, utils
11+
from .core import Configuration, Core
12+
from .errororacle import catch_unhandled_exception, error_oracle
13+
from .exceptions import FeatureFileNotFoundError, ScenarioNotFoundError
14+
from .extensionregistry import ExtensionRegistry
15+
from .hookregistry import HookRegistry
1316
from .loader import load_modules
1417
from .matcher import merge_steps
15-
from .stepregistry import StepRegistry
16-
from .hookregistry import HookRegistry
1718
from .runner import Runner
18-
from .extensionregistry import ExtensionRegistry
19-
from .exceptions import FeatureFileNotFoundError, ScenarioNotFoundError
20-
from .errororacle import error_oracle, catch_unhandled_exception
19+
from .stepregistry import StepRegistry
2120
from .terrain import world
22-
from . import utils
2321

2422
# use only 8 ANSI colors
2523
# FIXME(TF): change to true colors!

radish/parser.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,23 @@
33
One Feature file parser instance is able to parse one feature file.
44
"""
55

6-
import os
6+
import copy
7+
import filecmp
78
import io
8-
import re
99
import json
10-
import filecmp
11-
import copy
10+
import os
11+
import re
1212
import string
1313

14-
from .exceptions import RadishError, FeatureFileSyntaxError, LanguageNotSupportedError
14+
from . import utils
15+
from .background import Background
16+
from .exceptions import FeatureFileSyntaxError, LanguageNotSupportedError, RadishError
1517
from .feature import Feature
18+
from .model import Tag
1619
from .scenario import Scenario
17-
from .scenariooutline import ScenarioOutline
1820
from .scenarioloop import ScenarioLoop
21+
from .scenariooutline import ScenarioOutline
1922
from .stepmodel import Step
20-
from .background import Background
21-
from .model import Tag
22-
from . import utils
2323

2424

2525
class Keywords(object):

radish/runner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44

55
from random import shuffle
66

7-
from .terrain import world
8-
from .scenariooutline import ScenarioOutline
97
from .scenarioloop import ScenarioLoop
8+
from .scenariooutline import ScenarioOutline
109
from .stepmodel import Step
10+
from .terrain import world
1111

1212

1313
class Runner(object):

0 commit comments

Comments
 (0)