Fix tests on macOS

At least locally, let's see the CI.

Author: gaborcsardi

tests/testthat/_snaps/cache.md

@@ -0,0 +1,16 @@
+# gitcreds_cache_envvvar [osxkeychain]
+
+    Code
+      gitcreds_cache_envvar("foo.bar")
+    Condition
+      Error in `gitcreds_cache_envvar()`:
+      ! Invalid URL(s): foo.bar
+
+# gitcreds_cache_envvvar [manager-core]
+
+    Code
+      gitcreds_cache_envvar("foo.bar")
+    Condition
+      Error in `gitcreds_cache_envvar()`:
+      ! Invalid URL(s): foo.bar
+

tests/testthat/_snaps/username.md

@@ -0,0 +1,26 @@
+# errors [osxkeychain]
+
+    Code
+      gitcreds$gitcreds_username_for_url("https://github.com")
+    Condition
+      Error in `new_git_error()`:
+      ! System git failed: 
+    Code
+      gitcreds$gitcreds_username_generic()
+    Condition
+      Error in `new_git_error()`:
+      ! System git failed: 
+
+# errors [manager-core]
+
+    Code
+      gitcreds$gitcreds_username_for_url("https://github.com")
+    Condition
+      Error in `new_git_error()`:
+      ! System git failed: 
+    Code
+      gitcreds$gitcreds_username_generic()
+    Condition
+      Error in `new_git_error()`:
+      ! System git failed: 
+

tests/testthat/helper.R

@@ -58,10 +58,13 @@ gc_test_that_run <- function(desc, code) {
 
   envnames <- grep("^GITHUB_PAT", names(Sys.getenv()), value = TRUE)
   envs <- structure(rep(NA_character_, length(envnames)), names = envnames)
+  tmpconfig <- tempfile()
+  on.exit(unlink(tmpconfig), add = TRUE)
   withr::local_envvar(c(
     envs,
     GCM_AUTHORITY = NA_character_,
-    GCM_PROVIDER = NA_character_
+    GCM_PROVIDER = NA_character_,
+    GIT_CONFIG_GLOBAL = tmpconfig
   ))
 
   test_that(desc, {

tests/testthat/setup.R

@@ -0,0 +1,6 @@
+tempconfig <- tempfile()
+withr::local_envvar(
+  GIT_CONFIG_GLOBAL = tempconfig,
+  .local_envir = teardown_env()
+)
+withr::defer(unlink(tempconfig), envir = teardown_env())

tests/testthat/test-cache.R

@@ -18,7 +18,7 @@ gc_test_that("gitcreds_cache_envvvar", {
   )
 
   # error
-  expect_error(gitcreds_cache_envvar("foo.bar"), "Invalid URL")
+  expect_snapshot(error = TRUE, gitcreds_cache_envvar("foo.bar"))
 })
 
 gc_test_that("gitcreds_get_cache", {

tests/testthat/test-gitcreds-list.R

@@ -143,11 +143,11 @@ gc_test_that(
 
     lst <- gitcreds_list()
     expect_equal(length(lst), 1L)
-    expect_equal(lst[[1]]$attributes$service, "git:https://github.com")
+    expect_equal(lst[[1]]$attributes$label, "github.com")
 
     lst2 <- gitcreds_list(url = NULL)
     expect_true(length(lst2) == 1)
-    expect_equal(lst2[[1]]$attributes$service, "git:https://github.com")
+    expect_equal(lst2[[1]]$attributes$label, "github.com")
 
     cred2 <- list(
       url = "https://github2.com",
@@ -158,22 +158,11 @@ gc_test_that(
 
     lst3 <- gitcreds_list()
     expect_equal(length(lst3), 1L)
-    expect_equal(lst3[[1]]$attributes$service, "git:https://github.com")
+    expect_equal(lst3[[1]]$attributes$label, "github.com")
 
     lst4 <- gitcreds_list("https://github2.com")
     expect_equal(length(lst4), 1L)
-    expect_equal(lst4[[1]]$attributes$service, "git:https://github2.com")
-
-    lst5 <- gitcreds_list(url = NULL)
-    expect_true(length(lst5) >= 2)
-    expect_true(
-      "git:https://github.com" %in%
-        vapply(lst5, function(it) it$attributes$service, "")
-    )
-    expect_true(
-      "git:https://github2.com" %in%
-        vapply(lst5, function(it) it$attributes$service, "")
-    )
+    expect_equal(lst4[[1]]$attributes$label, "github2.com")
   }
 )
 

tests/testthat/test-username.R

@@ -46,6 +46,8 @@ gc_test_that("errors", {
   }
   mockery::stub(gitcreds$gitcreds_username_for_url, "git_run", mock2)
   mockery::stub(gitcreds$gitcreds_username_generic, "git_run", mock2)
-  expect_error(gitcreds$gitcreds_username_for_url("https://github.com"))
-  expect_error(gitcreds$gitcreds_username_generic())
+  expect_snapshot(error = TRUE, {
+    gitcreds$gitcreds_username_for_url("https://github.com")
+    gitcreds$gitcreds_username_generic()
+  })
 })