Skip to content

Commit 5d2cc89

Browse files
authored
Bump rdkafka to fix some issue with kafka 4.X.X and kraft (#5841)
* bump rdkafka to 0.38 * quickwit-indexing: fix pre_rebalance signature * indexing: fix clippy issue on kafka source * quickwit-indexing: fix formating
1 parent 6f0a1a9 commit 5d2cc89

File tree

3 files changed

+24
-55
lines changed

3 files changed

+24
-55
lines changed

quickwit/Cargo.lock

Lines changed: 21 additions & 52 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

quickwit/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ quote = "1.0"
188188
rand = "0.8"
189189
rand_distr = "0.4"
190190
rayon = "1.10"
191-
rdkafka = { version = "0.33", default-features = false, features = [
191+
rdkafka = { version = "0.38", default-features = false, features = [
192192
"cmake-build",
193193
"libz",
194194
"ssl",

quickwit/quickwit-indexing/src/source/kafka_source.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ macro_rules! return_if_err {
127127
/// The API of the rebalance callback is better explained in the docs of `librdkafka`:
128128
/// <https://docs.confluent.io/2.0.0/clients/librdkafka/classRdKafka_1_1RebalanceCb.html>
129129
impl ConsumerContext for RdKafkaContext {
130-
fn pre_rebalance(&self, rebalance: &Rebalance) {
130+
fn pre_rebalance(&self, _consumer: &BaseConsumer<Self>, rebalance: &Rebalance) {
131131
crate::metrics::INDEXER_METRICS.kafka_rebalance_total.inc();
132132
quickwit_common::rate_limited_info!(limit_per_min = 3, topic = self.topic, "rebalance");
133133
if let Rebalance::Revoke(tpl) = rebalance {
@@ -853,7 +853,7 @@ mod kafka_broker_tests {
853853
Duration::from_secs(1),
854854
)
855855
.await
856-
.map(|(partition, offset)| (id, partition, offset))
856+
.map(|delivery| (id, delivery.partition, delivery.offset))
857857
.map_err(|(err, _)| err)
858858
});
859859
let message_map = futures::future::try_join_all(tasks)

0 commit comments

Comments
 (0)