Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added provider struct method: GetCorrelatingEvent #41

Merged

Conversation

omri2001
Copy link
Contributor

@omri2001 omri2001 commented Jan 11, 2025

Description

Added a method to provider struct 'GetCorrelatingEvent' for translating workflow events into the corresponding provider.

Related Issue(s)

#29

Checklist

Before submitting this pull request, please ensure that you have completed the following tasks:

@omri2001 omri2001 requested a review from GoshaDo as a code owner January 11, 2025 19:25
@omri2001 omri2001 linked an issue Jan 11, 2025 that may be closed by this pull request
@omri2001
Copy link
Contributor Author

also on webhook_creator/main.go <line 96> there is a specific implementation for bitbucket which should also be handled, idk if you want to fix it in this pr or open another for it.
Currently left untouched

@omri2001 omri2001 force-pushed the 29-fix-add-provider-workflow-translation-mapping-to-provider branch from 6ee6b64 to e434217 Compare January 11, 2025 19:35
Copy link
Contributor

@GoshaDo GoshaDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you please add tests ?

@GoshaDo
Copy link
Contributor

GoshaDo commented Jan 12, 2025

also on webhook_creator/main.go <line 96> there is a specific implementation for bitbucket which should also be handled, idk if you want to fix it in this pr or open another for it. Currently left untouched

Maybe we should re-think the way to manage git provider at all..
Using a controller with CRDs maybe can help us ..

@GoshaDo GoshaDo merged commit f1e817f into main Jan 14, 2025
11 checks passed
@GoshaDo GoshaDo deleted the 29-fix-add-provider-workflow-translation-mapping-to-provider branch January 14, 2025 06:30
This was referenced Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: add provider-workflow translation mapping to provider
2 participants