fix: remove context propogation as pointer #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
context.Context is immutable:
The context.Context type and its implementations (e.g., context.Background(), context.WithCancel, context.WithTimeout) are immutable. Each operation that modifies a context (e.g., adding a deadline or attaching values) returns a new context.
This immutability means you can safely pass a context.Context by value without worrying about unintended side effects.
Interface Semantics:
context.Context is an interface, not a struct. When you pass it, you are effectively passing a pointer to the underlying implementation, even though it appears to be passed by value. This makes passing it by pointer unnecessary.
Checklist
Before submitting this pull request, please ensure that you have completed the following tasks: