Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic recovery for XA capable DataSources #47117

Open
mmusgrov opened this issue Apr 1, 2025 · 0 comments · May be fixed by #47118
Open

Disable automatic recovery for XA capable DataSources #47117

mmusgrov opened this issue Apr 1, 2025 · 0 comments · May be fixed by #47118
Labels
area/agroal area/narayana Transactions / Narayana kind/enhancement New feature or request

Comments

@mmusgrov
Copy link
Contributor

mmusgrov commented Apr 1, 2025

Description

When XA recovery is enabled then by default all XA capable datasources are registered with the transaction recovery system. The recent Agroal upgrade to version 2.6 (see Issue #47067 ) adds support for a config property to selectively disable adding such XA datasources for recovery and this proposal is to add a similar config property to the datasources extension config which will enable this feature. The javadoc for the property will be:

 * Whether to enable recover for this datasource.
 * <p>
 * Normally a transaction manager will call xa_recover () on an XA connection during recovery to obtain
 * a list of transaction branches that are currently in a prepared or heuristically completed state.
 * However, it can happen that multiple XA connections connect to the same database which would all
 * return the same set of branches and for reasons of improved performance only one should be used
 * for recover() calls. The default value for this configuration property is true because when there
 * is only one connection it is vital for data consistency that the connection is able to report its list of
 * prepared or heuristically completed branches.

Implementation ideas

No response

@mmusgrov mmusgrov added the kind/enhancement New feature or request label Apr 1, 2025
@mmusgrov mmusgrov linked a pull request Apr 1, 2025 that will close this issue
@geoand geoand added area/narayana Transactions / Narayana area/agroal and removed triage/needs-triage labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal area/narayana Transactions / Narayana kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants