Merge pull request #31 from 201-created/using-node-modules-path

Use ember-cli project `nodeModulesPath` when available

Author: quaertym

lib/dependency-checker.js

@@ -18,6 +18,15 @@ function EmberCLIDependencyChecker(project, reporter) {
   this.reporter = reporter;
 }
 
+// Legacy Ember-CLI (before 0.2.4) does not have a `nodeModulesPath` property
+function readNodeModulesPath(project) {
+  if (project.nodeModulesPath) {
+    return project.nodeModulesPath;
+  } else {
+    return path.join(project.root, 'node_modules');
+  }
+}
+
 EmberCLIDependencyChecker.prototype.checkDependencies = function() {
   if (alreadyChecked || process.env.SKIP_DEPENDENCY_CHECKER) {
     return;
@@ -51,19 +60,19 @@ EmberCLIDependencyChecker.prototype.readShrinkwrapDeps = function() {
     } catch(e) {
       // JSON parse error
     }
-    return ShrinkWrapChecker.checkDependencies(this.project.root, shrinkWrapJSON);
+    return ShrinkWrapChecker.checkDependencies(this.project.root, readNodeModulesPath(this.project), shrinkWrapJSON);
   } else {
     return [];
   }
 };
 
 EmberCLIDependencyChecker.prototype.lookupNodeModuleVersion = function(name) {
-  var nodePackage = path.join(this.project.root, 'node_modules', name, 'package.json');
+  var nodePackage = path.join(readNodeModulesPath(this.project), name, 'package.json');
   return this.lookupPackageVersion(nodePackage);
 };
 
 EmberCLIDependencyChecker.prototype.lookupBowerPackageVersion = function(name) {
-  var packageDirectory = path.join(this.project.root, this.project.bowerDirectory, name);
+  var packageDirectory = path.resolve(this.project.root, this.project.bowerDirectory, name);
   var version = null;
   if (fileExists(packageDirectory) && readDir(packageDirectory).length > 0) {
     var dotBowerFile = path.join(packageDirectory, '.bower.json');

lib/shrinkwrap-checker.js

@@ -19,12 +19,13 @@ ShrinkwrapChecker.prototype.check = function() {
     this.name, this.versionSpecified, versionInstalled, this.parents);
 };
 
-ShrinkwrapChecker.checkDependencies = function(root, shrinkWrapJSON) {
+ShrinkwrapChecker.checkDependencies = function(root, nodeModulesPath, shrinkWrapJSON) {
   var resolvedDependencies = [];
   var currentNode;
 
   var nodesToCheck = [{
     root: root,
+    nodeModulesPath: nodeModulesPath,
     parents: [],
     childDependencies: shrinkWrapJSON.dependencies,
     name: shrinkWrapJSON.name,
@@ -46,8 +47,11 @@ ShrinkwrapChecker.checkDependencies = function(root, shrinkWrapJSON) {
       Object.keys(currentNode.childDependencies).forEach(function(childDepName){
         var childDep = currentNode.childDependencies[childDepName];
 
+        var root = path.join(currentNode.nodeModulesPath, childDepName);
+        var nodeModulesPath = path.join(root, 'node_modules');
         nodesToCheck.push({
-          root: path.join(currentNode.root, 'node_modules', childDepName),
+          root: root,
+          nodeModulesPath: nodeModulesPath,
           parents: parents,
           name: childDepName,
           childDependencies: childDep.dependencies,

tests/fixtures/project-npm-sibling-node-modules-check/app/bower.json

@@ -0,0 +1,5 @@
+{
+  "name": "project-npm-check",
+  "dependencies": {
+  }
+}

tests/fixtures/project-npm-sibling-node-modules-check/node_modules/ember-cli/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "test",
+  "version": "1.0.0"
+}

tests/fixtures/project-shrinkwrap-sibling-node-modules-check/app/npm-shrinkwrap.json

@@ -0,0 +1,52 @@
+'use strict';
+
+var defaultProject, projectBuilder;
+
+function simpleMerge(target, object) {
+  var merged = Object.create(target);
+  for (var key in object) {
+    merged[key] = object[key];
+  }
+  return merged;
+}
+
+/*
+ * Usage:
+ *
+ * var project = projectBuilder.build({
+ *   dependencies: projectBuilder.buildDependencies([
+ *     { some: object }
+ *   ],
+ *   root: 'some/alternative/root'
+ * });
+ *
+ *
+ */
+projectBuilder = {
+
+  build: function projectBuilder$build(configuredProject) {
+    var project = simpleMerge(defaultProject, configuredProject || {});
+    return project;
+  },
+
+  buildDependencies: function projectBuilder$buildDependencies(dependencies) {
+    return function(){
+      return dependencies || {};
+    };
+  },
+
+  buildBowerDependencies: function projectBuilder$buildBowerDependencies(dependencies) {
+    return function(){
+      return dependencies || {};
+    };
+  }
+};
+
+defaultProject = {
+  root: 'tests/fixtures/project-npm-check',
+  bowerDirectory: 'bower_components',
+  dependencies: projectBuilder.buildDependencies(),
+  bowerDependencies: projectBuilder.buildBowerDependencies()
+};
+
+module.exports = projectBuilder;

tests/fixtures/project-shrinkwrap-sibling-node-modules-check/app/package.json

@@ -3,24 +3,19 @@
 var assertError   = require('../helpers/assert-error');
 var assertNoError = require('../helpers/assert-no-error');
 var DependencyChecker = require('../../lib/dependency-checker');
+var projectBuilder = require('../helpers/project-builder');
 
 describe('EmberCLIDependencyChecker', function() {
   beforeEach(function(){
     DependencyChecker.setAlreadyChecked(false);
   });
 
-  var createProject = function(bowerDependencies) {
-    return {
+  function createProject(bowerDependencies) {
+    return projectBuilder.build({
       root: 'tests/fixtures/project-bower-check',
-      bowerDirectory: 'bower_components',
-      dependencies: function() {
-        return {};
-      },
-      bowerDependencies: function() {
-        return bowerDependencies || {};
-      }
-    };
-  };
+      bowerDependencies: projectBuilder.buildBowerDependencies(bowerDependencies)
+    });
+  }
 
   var assertBowerError = function(project) {
     return assertError(project, 'bower');

tests/fixtures/project-shrinkwrap-sibling-node-modules-check/node_modules/minimist/package.json

@@ -3,24 +3,19 @@
 var assertError   = require('../helpers/assert-error');
 var assertNoError = require('../helpers/assert-no-error');
 var DependencyChecker = require('../../lib/dependency-checker');
+var projectBuilder = require('../helpers/project-builder');
 
 describe('EmberCLIDependencyChecker', function() {
   beforeEach(function(){
     DependencyChecker.setAlreadyChecked(false);
   });
 
-  var createProject = function(dependencies) {
-    return {
-      root: 'tests/fixtures/project-npm-check',
-      bowerDirectory: 'bower_components',
-      dependencies: function() {
-        return dependencies || {};
-      },
-      bowerDependencies: function() {
-        return {};
-      }
-    };
-  };
+  function createProject(dependencies, options) {
+    options = options || {};
+    options.root = options.root || 'tests/fixtures/project-npm-check';
+    options.dependencies = projectBuilder.buildDependencies(dependencies);
+    return projectBuilder.build(options);
+  }
 
   var assertNpmError = function(project) {
     return assertError(project, 'npm');
@@ -93,4 +88,16 @@ describe('EmberCLIDependencyChecker', function() {
       assertNoNpmError(project);
     });
   });
+
+  describe('sibling node_modules/ directory', function() {
+    it('checks depdencies', function() {
+      var project = createProject({
+        'ember-cli': '*'
+      }, {
+        root: 'tests/fixtures/project-npm-sibling-node-modules-check/app',
+        nodeModulesPath: 'tests/fixtures/project-npm-sibling-node-modules-check/node_modules',
+      });
+      assertNoNpmError(project);
+    });
+  });
 });