Skip to content

Commit deed134

Browse files
committed
Reorder keycodes with prior references to KC_MISSION_CONTROL/KC_LAUNCHPAD to cater for VIA definitions.
1 parent 3e70863 commit deed134

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

keyboards/keychron/common/keychron_common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "quantum_keycodes.h"
2424

2525
enum custom_keycodes {
26-
KC_LOPTN = QK_KB_0,
26+
KC_LOPTN = QK_KB_2, // TECH DEBT: Starts at QK_KB_2 to maintain ordering with VIA definitions. See #19884. Revert to QK_KB_0 when VIA catches up with QMK.
2727
KC_ROPTN,
2828
KC_LCMMD,
2929
KC_RCMMD,

keyboards/keychron/q1/ansi/keymaps/mkillewald/keymap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ typedef union {
3535
user_config_t user_config;
3636

3737
enum custom_keycodes {
38-
KC_LIGHT_TAB_TOGGLE = QK_KB_0,
38+
KC_LIGHT_TAB_TOGGLE = QK_KB_2, // TECH DEBT: Starts at QK_KB_2 to maintain ordering with VIA definitions. See #19884. Revert to QK_KB_0 when VIA catches up with QMK.
3939
KC_LIGHT_ALPHAS_TOGGLE,
4040
KC_FN_LAYER_TRANSPARENT_KEYS_TOGGLE,
4141
KC_FN_LAYER_COLOR_TOGGLE

keyboards/keychron/q1/iso/keymaps/mkillewald_iso/keymap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ typedef union {
3535
user_config_t user_config;
3636

3737
enum custom_keycodes {
38-
KC_LIGHT_TAB_TOGGLE = QK_KB_0,
38+
KC_LIGHT_TAB_TOGGLE = QK_KB_2, // TECH DEBT: Starts at QK_KB_2 to maintain ordering with VIA definitions. See #19884. Revert to QK_KB_0 when VIA catches up with QMK.
3939
KC_LIGHT_ALPHAS_TOGGLE,
4040
KC_FN_LAYER_TRANSPARENT_KEYS_TOGGLE,
4141
KC_FN_LAYER_COLOR_TOGGLE

keyboards/keychron/q2/ansi/keymaps/via/keymap.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ enum layers{
2424
_FN3
2525
};
2626

27-
enum custom_keycodes {
28-
KC_TASK = QK_KB_0,
29-
KC_FLXP
30-
};
31-
3227
#define KC_TASK LGUI(KC_TAB)
3328
#define KC_FLXP LGUI(KC_E)
3429

0 commit comments

Comments
 (0)