Skip to content

Commit dadb44b

Browse files
Merge pull request qiskit-community/qiskit-aqua#851 from manoelmarques/refactor
Refactor classes and file names from classical to numpy
2 parents 18df5d4 + a0a54fc commit dadb44b

12 files changed

+36
-31
lines changed

qiskit/optimization/ising/docplex.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
qubitOp, offset = get_operator(mdl)
5353
5454
# Calculate with the generated Ising Hamiltonian.
55-
ee = ClassicalMinimumEigensolver(qubitOp)
55+
ee = NumPyMinimumEigensolver(qubitOp)
5656
result = ee.run()
5757
print('get_operator')
5858
print('tsp objective:', result['energy'] + offset)

test/optimization/test_clique.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from qiskit.aqua import aqua_globals, QuantumInstance
2222
from qiskit.optimization.ising import clique
2323
from qiskit.optimization.ising.common import random_graph, sample_most_likely
24-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver, VQE
24+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver, VQE
2525
from qiskit.aqua.components.optimizers import COBYLA
2626
from qiskit.aqua.components.variational_forms import RY
2727

@@ -57,7 +57,7 @@ def bitfield(n, length):
5757

5858
def test_clique(self):
5959
""" Clique test """
60-
algo = ClassicalMinimumEigensolver(self.qubit_op, aux_operators=[])
60+
algo = NumPyMinimumEigensolver(self.qubit_op, aux_operators=[])
6161
result = algo.run()
6262
x = sample_most_likely(result.eigenstate)
6363
ising_sol = clique.get_graph_solution(x)

test/optimization/test_docplex.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from qiskit.quantum_info import Pauli
2424

2525
from qiskit.aqua import AquaError, aqua_globals
26-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver
26+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver
2727
from qiskit.optimization.ising import docplex, tsp
2828
from qiskit.aqua.operators import WeightedPauliOperator
2929

@@ -230,10 +230,10 @@ def test_docplex_maxcut(self):
230230
mdl.maximize(maxcut_func)
231231
qubit_op, offset = docplex.get_operator(mdl)
232232

233-
e_e = ClassicalMinimumEigensolver(qubit_op)
233+
e_e = NumPyMinimumEigensolver(qubit_op)
234234
result = e_e.run()
235235

236-
ee_expected = ClassicalMinimumEigensolver(QUBIT_OP_MAXCUT)
236+
ee_expected = NumPyMinimumEigensolver(QUBIT_OP_MAXCUT)
237237
expected_result = ee_expected.run()
238238

239239
# Compare objective
@@ -264,10 +264,10 @@ def test_docplex_tsp(self):
264264
mdl.add_constraint(mdl.sum(x[(i, j)] for i in range(num_node)) == 1)
265265
qubit_op, offset = docplex.get_operator(mdl)
266266

267-
e_e = ClassicalMinimumEigensolver(qubit_op)
267+
e_e = NumPyMinimumEigensolver(qubit_op)
268268
result = e_e.run()
269269

270-
ee_expected = ClassicalMinimumEigensolver(QUBIT_OP_TSP)
270+
ee_expected = NumPyMinimumEigensolver(QUBIT_OP_TSP)
271271
expected_result = ee_expected.run()
272272

273273
# Compare objective
@@ -284,7 +284,7 @@ def test_docplex_integer_constraints(self):
284284
mdl.add_constraint(mdl.sum(i * x[i] for i in range(1, 5)) == 3)
285285
qubit_op, offset = docplex.get_operator(mdl)
286286

287-
e_e = ClassicalMinimumEigensolver(qubit_op)
287+
e_e = NumPyMinimumEigensolver(qubit_op)
288288
result = e_e.run()
289289

290290
expected_result = -2
@@ -313,7 +313,7 @@ def test_docplex_constant_and_quadratic_terms_in_object_function(self):
313313
mdl.minimize(ising_func)
314314
qubit_op, offset = docplex.get_operator(mdl)
315315

316-
e_e = ClassicalMinimumEigensolver(qubit_op)
316+
e_e = NumPyMinimumEigensolver(qubit_op)
317317
result = e_e.run()
318318

319319
expected_result = -22

test/optimization/test_exact_cover.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from qiskit.aqua import aqua_globals, QuantumInstance
2323
from qiskit.optimization.ising import exact_cover
2424
from qiskit.optimization.ising.common import sample_most_likely
25-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver, VQE
25+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver, VQE
2626
from qiskit.aqua.components.optimizers import COBYLA
2727
from qiskit.aqua.components.variational_forms import RYRZ
2828

@@ -57,7 +57,7 @@ def bitfield(n, length):
5757

5858
def test_exact_cover(self):
5959
""" Exact Cover test """
60-
algo = ClassicalMinimumEigensolver(self.qubit_op, aux_operators=[])
60+
algo = NumPyMinimumEigensolver(self.qubit_op, aux_operators=[])
6161
result = algo.run()
6262
x = sample_most_likely(result.eigenstate)
6363
ising_sol = exact_cover.get_solution(x)

test/optimization/test_graph_partition.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from qiskit.aqua import aqua_globals, QuantumInstance
2121
from qiskit.optimization.ising import graph_partition
2222
from qiskit.optimization.ising.common import random_graph, sample_most_likely
23-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver, VQE
23+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver, VQE
2424
from qiskit.aqua.components.variational_forms import RY
2525
from qiskit.aqua.components.optimizers import SPSA
2626

@@ -58,7 +58,7 @@ def bitfield(n, length):
5858

5959
def test_graph_partition(self):
6060
""" Graph Partition test """
61-
algo = ClassicalMinimumEigensolver(self.qubit_op, aux_operators=[])
61+
algo = NumPyMinimumEigensolver(self.qubit_op, aux_operators=[])
6262
result = algo.run()
6363
x = sample_most_likely(result.eigenstate)
6464
# check against the oracle

test/optimization/test_partition.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from qiskit.aqua import aqua_globals, QuantumInstance
2121
from qiskit.optimization.ising import partition
2222
from qiskit.optimization.ising.common import read_numbers_from_file, sample_most_likely
23-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver, VQE
23+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver, VQE
2424
from qiskit.aqua.components.optimizers import SPSA
2525
from qiskit.aqua.components.variational_forms import RY
2626

@@ -36,7 +36,7 @@ def setUp(self):
3636

3737
def test_partition(self):
3838
""" Partition test """
39-
algo = ClassicalMinimumEigensolver(self.qubit_op, aux_operators=[])
39+
algo = NumPyMinimumEigensolver(self.qubit_op, aux_operators=[])
4040
result = algo.run()
4141
x = sample_most_likely(result.eigenstate)
4242
np.testing.assert_array_equal(x, [0, 1, 0])

test/optimization/test_readme_sample.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@ class TestReadmeSample(QiskitOptimizationTestCase):
2727

2828
def test_readme_sample(self):
2929
""" readme sample test """
30-
# pylint: disable=import-outside-toplevel
30+
# pylint: disable=import-outside-toplevel,redefined-builtin
31+
32+
def print(*args):
33+
""" overloads print to log values """
34+
if args:
35+
self.log.debug(args[0], *args[1:])
3136

3237
# --- Exact copy of sample code ----------------------------------------
3338

@@ -75,10 +80,10 @@ def test_readme_sample(self):
7580
seed_transpiler=seed)
7681
result = qaoa.run(quantum_instance)
7782

78-
x = sample_most_likely(result['eigvecs'][0])
79-
print('energy:', result['energy'])
80-
print('time:', result['eval_time'])
81-
print('max-cut objective:', result['energy'] + offset)
83+
x = sample_most_likely(result.eigenstate)
84+
print('energy:', result.eigenvalue.real)
85+
print('time:', result.optimizer_time)
86+
print('max-cut objective:', result.eigenvalue.real + offset)
8287
print('solution:', max_cut.get_graph_solution(x))
8388
print('solution objective:', max_cut.max_cut_value(x, w))
8489

test/optimization/test_set_packing.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from qiskit.optimization.ising import set_packing
2222
from qiskit.optimization.ising.common import sample_most_likely
2323
from qiskit.aqua import QuantumInstance, aqua_globals
24-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver, VQE
24+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver, VQE
2525
from qiskit.aqua.components.optimizers import SPSA
2626
from qiskit.aqua.components.variational_forms import RY
2727

@@ -55,7 +55,7 @@ def bitfield(n, length):
5555

5656
def test_set_packing(self):
5757
""" set packing test """
58-
algo = ClassicalMinimumEigensolver(self.qubit_op, aux_operators=[])
58+
algo = NumPyMinimumEigensolver(self.qubit_op, aux_operators=[])
5959
result = algo.run()
6060
x = sample_most_likely(result.eigenstate)
6161
ising_sol = set_packing.get_solution(x)

test/optimization/test_stable_set.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from qiskit.aqua import aqua_globals, QuantumInstance
2222
from qiskit.optimization.ising import stable_set
2323
from qiskit.optimization.ising.common import random_graph, sample_most_likely
24-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver, VQE
24+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver, VQE
2525
from qiskit.aqua.components.optimizers import L_BFGS_B
2626
from qiskit.aqua.components.variational_forms import RYRZ
2727

@@ -39,7 +39,7 @@ def setUp(self):
3939

4040
def test_stable_set(self):
4141
""" Stable set test """
42-
algo = ClassicalMinimumEigensolver(self.qubit_op, aux_operators=[])
42+
algo = NumPyMinimumEigensolver(self.qubit_op, aux_operators=[])
4343
result = algo.run()
4444
x = sample_most_likely(result.eigenstate)
4545
self.assertAlmostEqual(result.eigenvalue.real, -29.5)

test/optimization/test_tsp.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from qiskit.aqua import aqua_globals
2121
from qiskit.optimization.ising import tsp
2222
from qiskit.optimization.ising.common import sample_most_likely
23-
from qiskit.aqua.algorithms import ClassicalMinimumEigensolver
23+
from qiskit.aqua.algorithms import NumPyMinimumEigensolver
2424

2525

2626
class TestTSP(QiskitOptimizationTestCase):
@@ -36,7 +36,7 @@ def setUp(self):
3636

3737
def test_tsp(self):
3838
""" TSP test """
39-
algo = ClassicalMinimumEigensolver(self.qubit_op)
39+
algo = NumPyMinimumEigensolver(self.qubit_op)
4040
result = algo.run()
4141
x = sample_most_likely(result.eigenstate)
4242
order = tsp.get_tsp_solution(x)

0 commit comments

Comments
 (0)