Skip to content

Deprecate and move ad_hoc dataset to another place #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
adekusar-drl opened this issue Feb 18, 2022 · 6 comments
Closed
1 of 3 tasks

Deprecate and move ad_hoc dataset to another place #330

adekusar-drl opened this issue Feb 18, 2022 · 6 comments
Labels
priority: low type: enhancement ✨ Features or aspects to improve

Comments

@adekusar-drl
Copy link
Collaborator

adekusar-drl commented Feb 18, 2022

What is the expected enhancement?

While most of the datasets have been deprecated in #319 the ad_hoc dataset is available in the module. This dataset is used in a few places and this issue is created to consider deprecation of this dataset as well. Perhaps, it should be kept somewhere else.

The places where ad_hoc is used so far:

Before the dataset is deprecated the above mentioned places must be updated.

@adekusar-drl adekusar-drl added type: enhancement ✨ Features or aspects to improve priority: low labels Feb 18, 2022
@andrenmelo
Copy link
Contributor

FYI I'm planning to rewrite ad_hoc and also and generalize to several qubits for my own research. Happy to help port it somewhere else too.

@adekusar-drl
Copy link
Collaborator Author

While ad_hoc is still here, you can open PRs with updates. It will take some time to decide how to proceed since the dataset is in use.

@edoaltamura
Copy link
Collaborator

@adekusar-drl where are the ad-hoc-like datasets for qiskit-community usually stored? Is the overall idea to move datasets into a different repository and add that as a dependency of machine-learning for tests and tutorials?

@edoaltamura
Copy link
Collaborator

@adekusar-drl @woodsp-ibm #902 extends the ad_hoc dataset, but what would you advise regarding the deprecation aspect? I saw there used to be more datasets, then removed in #319. What was the reason for deprecating?
While iris or wine can be fetched from elsewhere in principle, ad_hoc is 'unique' to QML as it comes from the Havlicek+2019 paper, so it might be worth keeping in the repo.

@adekusar-drl
Copy link
Collaborator Author

Honestly, I don't remember the details of the original issue, but the datasets from scikit-learn are easy to deal with and that's why they have been removed. Yes, you are right, ad_hoc is a unique one and since then I have change my mind I'd keep it as a pure quantum dataset.

@edoaltamura
Copy link
Collaborator

Great! In that case, #902 closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low type: enhancement ✨ Features or aspects to improve
Projects
None yet
Development

No branches or pull requests

3 participants