Remove the boolean logic gates (#896)

* deprecate  boolean logic gates

* fix mcmt import

the test relied on the implicit import of mcmt via FixedValueComparator

* add changelog

* completely remove and/or from gates

Co-authored-by: Manoel Marques <[email protected]>

Author: Cryoris

CHANGELOG.md

@@ -41,8 +41,10 @@ Removed
 -------
 
 -   Declarative api (#758) (#759) (#760) (#762) (#763)
--   Moved to Terra: multi-controlled Toffoli, U1 and Pauli rotation gates (including tests) (#833)
--   Moved to the circuit library in Terra: arithmetic circuits in qiskit/aqua/circuits (#895)
+-   Moved to Terra:
+    -   multi-controlled Toffoli, U1 and Pauli rotation gates (including tests) (#833)
+    -   arithmetic circuits in qiskit/aqua/circuits (#895)
+    -   boolean logic gates (#896)
 
 Fixed
 -----

qiskit/aqua/circuits/fixed_value_comparator.py

@@ -19,9 +19,6 @@
 
 from qiskit.circuit.library import IntegerComparator
 from qiskit.aqua.utils.circuit_factory import CircuitFactory
-from qiskit.aqua.circuits.gates import logical_or  # pylint: disable=unused-import
-
-# pylint: disable=invalid-name
 
 
 class FixedValueComparator(CircuitFactory):
@@ -92,8 +89,7 @@ def required_ancillas_controlled(self):
         return self.num_state_qubits - 1
 
     def _get_twos_complement(self):
-        """
-        Returns the 2's complement of value as array
+        """Returns the 2's complement of value as array
 
         Returns:
              list: two's complement

qiskit/aqua/circuits/gates/__init__.py

@@ -30,16 +30,11 @@
    :nosignatures:
 
     mcmt
-    logical_and
-    logical_or
 
 """
 
 from .multi_control_multi_target_gate import mcmt
-from .boolean_logical_gates import logical_and, logical_or
 
 __all__ = [
     'mcmt',
-    'logical_and',
-    'logical_or',
 ]

qiskit/aqua/circuits/gates/boolean_logical_gates.py

@@ -23,6 +23,8 @@
 from qiskit import execute as q_execute
 from qiskit.quantum_info import state_fidelity
 from qiskit import BasicAer
+# pylint:disable=unused-import
+from qiskit.aqua.circuits.gates import multi_control_multi_target_gate
 
 NUM_CONTROLS = [i + 1 for i in range(7)]
 NUM_TARGETS = [i + 1 for i in range(5)]