You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The numpy version is currently pinned to 1.24 because test_imfil in the test_optimizers_scikitquant.py module breaks with 1.25 (somewhere internal to the imfil optimizer when saving its history). There are 2 possible ways we could avoid this pinning
We could add a numpy version check to test_imfil, similar to what is done with the SnobFit tests in that same test module, which are skipped based on a numpy version check.
The scikit-quant pkg has not been updated in a couple of years, at some point we might want to think whether to keep it at all. If someone really wants to use it, they could still do it via some partial on their minimize.
The text was updated successfully, but these errors were encountered:
I think I would go with 1. above for now which will allow us to get rid of the constraint and just not run that specific test. Though I think it works it fails because internally it raises a deprecation warning which the Qiskit base test class treats as an error #11.
Later we may want to consider 2 above, which if this issue is closed by virtue of doing 1 above we may want to create a separate issue for.
What should we add?
The numpy version is currently pinned to 1.24 because
test_imfil
in thetest_optimizers_scikitquant.py
module breaks with 1.25 (somewhere internal to theimfil
optimizer when saving its history). There are 2 possible ways we could avoid this pinningtest_imfil
, similar to what is done with the SnobFit tests in that same test module, which are skipped based on a numpy version check.scikit-quant
pkg has not been updated in a couple of years, at some point we might want to think whether to keep it at all. If someone really wants to use it, they could still do it via some partial on their minimize.The text was updated successfully, but these errors were encountered: