Skip to content

Address numpy<1.25 constraint #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ElePT opened this issue Jul 21, 2023 · 1 comment · Fixed by #83
Closed

Address numpy<1.25 constraint #10

ElePT opened this issue Jul 21, 2023 · 1 comment · Fixed by #83

Comments

@ElePT
Copy link
Collaborator

ElePT commented Jul 21, 2023

What should we add?

The numpy version is currently pinned to 1.24 because test_imfil in the test_optimizers_scikitquant.py module breaks with 1.25 (somewhere internal to the imfil optimizer when saving its history). There are 2 possible ways we could avoid this pinning

  1. We could add a numpy version check to test_imfil, similar to what is done with the SnobFit tests in that same test module, which are skipped based on a numpy version check.
  2. The scikit-quant pkg has not been updated in a couple of years, at some point we might want to think whether to keep it at all. If someone really wants to use it, they could still do it via some partial on their minimize.
@woodsp-ibm
Copy link
Member

I think I would go with 1. above for now which will allow us to get rid of the constraint and just not run that specific test. Though I think it works it fails because internally it raises a deprecation warning which the Qiskit base test class treats as an error #11.

Later we may want to consider 2 above, which if this issue is closed by virtue of doing 1 above we may want to create a separate issue for.

@woodsp-ibm woodsp-ibm added this to the 0.1.0 milestone Jul 24, 2023
@woodsp-ibm woodsp-ibm changed the title Adress numpy<1.25 constraint Address numpy<1.25 constraint Jul 24, 2023
@woodsp-ibm woodsp-ibm removed this from the 0.1.0 milestone Jul 27, 2023
@mergify mergify bot closed this as completed in #83 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants