Skip to content

Commit 4deb792

Browse files
committed
Fix bug: uninitialized vlantype_name
1 parent 6366538 commit 4deb792

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/sonic-config-engine/minigraph.py

+8-5
Original file line numberDiff line numberDiff line change
@@ -527,14 +527,15 @@ def parse_dpg(dpg, hname):
527527
vlans = {}
528528
vlan_members = {}
529529
dhcp_relay_table = {}
530-
vlantype_name = ""
531530
# Dict: vlan member (port/PortChannel) -> set of VlanID, in which the member if an untagged vlan member
532531
untagged_vlan_mbr = defaultdict(set)
533532
for vintf in vlanintfs.findall(str(QName(ns, "VlanInterface"))):
534533
vlanid = vintf.find(str(QName(ns, "VlanID"))).text
535534
vlantype = vintf.find(str(QName(ns, "Type")))
536-
if vlantype != None:
537-
vlantype_name = vintf.find(str(QName(ns, "Type"))).text
535+
if vlantype is None:
536+
vlantype_name = ""
537+
else:
538+
vlantype_name = vlantype.text
538539
vintfmbr = vintf.find(str(QName(ns, "AttachTo"))).text
539540
vmbr_list = vintfmbr.split(';')
540541
if vlantype_name != "Tagged":
@@ -545,8 +546,10 @@ def parse_dpg(dpg, hname):
545546
vlanid = vintf.find(str(QName(ns, "VlanID"))).text
546547
vintfmbr = vintf.find(str(QName(ns, "AttachTo"))).text
547548
vlantype = vintf.find(str(QName(ns, "Type")))
548-
if vlantype != None:
549-
vlantype_name = vintf.find(str(QName(ns, "Type"))).text
549+
if vlantype is None:
550+
vlantype_name = ""
551+
else:
552+
vlantype_name = vlantype.text
550553
vmbr_list = vintfmbr.split(';')
551554
for i, member in enumerate(vmbr_list):
552555
vmbr_list[i] = port_alias_map.get(member, member)

0 commit comments

Comments
 (0)