Skip to content

Commit b2bdc4a

Browse files
authored
Merge pull request #61563 from alexbruy/processing-checkvalidity-cpp
port Check Validity algorithm to C++
2 parents 1a62581 + f2b9f60 commit b2bdc4a

11 files changed

+359
-453
lines changed

python/plugins/processing/algs/help/qgis.yaml

-9
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,6 @@ qgis:barplot: >
77
qgis:boxplot: >
88
This algorithm creates a box plot from a category and a layer field.
99

10-
qgis:checkvalidity: >
11-
This algorithm performs a validity check on the geometries of a vector layer.
12-
13-
The geometries are classified in three groups (valid, invalid and error), and a vector layer is generated with the features in each of these categories.
14-
15-
By default the algorithm uses the strict OGC definition of polygon validity, where a polygon is marked as invalid if a self-intersecting ring causes an interior hole. If the "Ignore ring self intersections" option is checked, then this rule will be ignored and a more lenient validity check will be performed.
16-
17-
The GEOS method is faster and performs better on larger geometries, but is limited to only returning the first error encountered in a geometry. The QGIS method will be slower but reports all errors encountered in the geometry, not just the first.
18-
1910
qgis:climbalongline: >
2011
This algorithm calculates the total climb and descent along line geometries.
2112

python/plugins/processing/algs/qgis/CheckValidity.py

-297
This file was deleted.

python/plugins/processing/algs/qgis/QgisAlgorithmProvider.py

-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727

2828
from .BarPlot import BarPlot
2929
from .BoxPlot import BoxPlot
30-
from .CheckValidity import CheckValidity
3130
from .Climb import Climb
3231
from .EliminateSelection import EliminateSelection
3332
from .ExecuteSQL import ExecuteSQL
@@ -90,7 +89,6 @@ def getAlgs(self):
9089
algs = [
9190
BarPlot(),
9291
BoxPlot(),
93-
CheckValidity(),
9492
Climb(),
9593
EliminateSelection(),
9694
ExecuteSQL(),

python/plugins/processing/tests/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,5 @@ if(ENABLE_TESTS)
2121
ADD_PYTHON_TEST(ProcessingGdalAlgorithmsGeneralTest GdalAlgorithmsGeneralTest.py)
2222
ADD_PYTHON_TEST(ProcessingGdalAlgorithmsRasterTest GdalAlgorithmsRasterTest.py)
2323
ADD_PYTHON_TEST(ProcessingGdalAlgorithmsVectorTest GdalAlgorithmsVectorTest.py)
24-
ADD_PYTHON_TEST(ProcessingCheckValidityAlgorithmTest CheckValidityAlgorithm.py)
2524
ADD_PYTHON_TEST(ProcessingScriptUtilsTest ScriptUtilsTest.py)
2625
endif()

0 commit comments

Comments
 (0)