Skip to content

Maintenance: validate domain strings for all providers #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qdm12 opened this issue Feb 3, 2024 · 4 comments · Fixed by #638
Closed

Maintenance: validate domain strings for all providers #626

qdm12 opened this issue Feb 3, 2024 · 4 comments · Fixed by #638
Labels
Category: Maintenance ⛓️ Anything related to code or other maintenance Category: Provider update ♻️ Status: 🔒 After next release Will be done after the next release

Comments

@qdm12
Copy link
Owner

qdm12 commented Feb 3, 2024

All domain strings are not validated for now. It would be good to check at a global scope the domain is

  • empty
  • a valid fqdn (without trail dot)

Some providers only use a host and the domain json value can be the empty string (constant value in the code), for example duckdns the domain is always duckdns.org. goip.de can have the domain empty, which defaults to goip.de, but it can also be set for example to goip.it.

@qdm12 qdm12 added Status: 🔒 After next release Will be done after the next release Category: Provider update ♻️ Category: Maintenance ⛓️ Anything related to code or other maintenance labels Feb 3, 2024
@CyberAustin
Copy link
Contributor

I'm taking a stab at this right now. Mostly got it working, just need to get the code to my dev machine at home so I can run all the linting and formatting.

@qdm12
Copy link
Owner Author

qdm12 commented Feb 7, 2024

Awesome (no pressure either)
You can probably develop with the development container (see .devcontainer directory) if you have Docker and VSCode installed, that's what I use (from a directory in WSL2 on windows)

@CyberAustin
Copy link
Contributor

Yeah, I use your include dev container. It's just that I'm at work and only have access to limited resources during work hours.

@CyberAustin
Copy link
Contributor

PR created: #638

@qdm12 qdm12 closed this as completed in #638 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Maintenance ⛓️ Anything related to code or other maintenance Category: Provider update ♻️ Status: 🔒 After next release Will be done after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants