Skip to content

Commit d7ad1b3

Browse files
authored
libtinfo.so version update and logic fix for ROCm libtorch (#1270)
* Use libtinfo.so.6 for Ubuntu 2004 * Fix to origname grep * Condition on ROCM_VERSION for libtinfo6
1 parent e40ab7c commit d7ad1b3

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

manywheel/build_common.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ replace_needed_sofiles() {
281281
patchedname=$3
282282
if [[ "$origname" != "$patchedname" ]] || [[ "$DESIRED_CUDA" == *"rocm"* ]]; then
283283
set +e
284-
origname=$($PATCHELF_BIN --print-needed $sofile | grep "$origname*")
284+
origname=$($PATCHELF_BIN --print-needed $sofile | grep "$origname.*")
285285
ERRCODE=$?
286286
set -e
287287
if [ "$ERRCODE" -eq "0" ]; then

manywheel/build_libtorch.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ for pkg in /$LIBTORCH_HOUSE_DIR/libtorch*.zip; do
303303
patchedname=${patched[i]}
304304
if [[ "$origname" != "$patchedname" ]] || [[ "$DESIRED_CUDA" == *"rocm"* ]]; then
305305
set +e
306-
origname=$($PATCHELF_BIN --print-needed $sofile | grep "$origname*")
306+
origname=$($PATCHELF_BIN --print-needed $sofile | grep "$origname.*")
307307
ERRCODE=$?
308308
set -e
309309
if [ "$ERRCODE" -eq "0" ]; then

manywheel/build_rocm.sh

+5-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,11 @@ elif [[ "$OS_NAME" == *"Ubuntu"* ]]; then
114114
LIBGOMP_PATH="/usr/lib/x86_64-linux-gnu/libgomp.so.1"
115115
LIBNUMA_PATH="/usr/lib/x86_64-linux-gnu/libnuma.so.1"
116116
LIBELF_PATH="/usr/lib/x86_64-linux-gnu/libelf.so.1"
117-
LIBTINFO_PATH="/lib/x86_64-linux-gnu/libtinfo.so.5"
117+
if [[ $ROCM_INT -ge 50300 ]]; then
118+
LIBTINFO_PATH="/lib/x86_64-linux-gnu/libtinfo.so.6"
119+
else
120+
LIBTINFO_PATH="/lib/x86_64-linux-gnu/libtinfo.so.5"
121+
fi
118122
LIBDRM_PATH="/usr/lib/x86_64-linux-gnu/libdrm.so.2"
119123
LIBDRM_AMDGPU_PATH="/usr/lib/x86_64-linux-gnu/libdrm_amdgpu.so.1"
120124
MAYBE_LIB64=lib

0 commit comments

Comments
 (0)