Skip to content

Commit 96e999c

Browse files
committed
testing
1 parent 791a751 commit 96e999c

File tree

3 files changed

+24
-52
lines changed

3 files changed

+24
-52
lines changed

.github/workflows/validate-binaries.yml

+2-9
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ on:
2121
inputs:
2222
os:
2323
description: "Operating system to generate for (linux, windows, macos, macos-arm64)"
24-
required: false
24+
required: true
2525
type: choice
2626
default: all
2727
options:
@@ -31,21 +31,14 @@ on:
3131
- all
3232
channel:
3333
description: "Channel to use (nightly, test, release, all)"
34-
required: false
34+
required: true
3535
type: choice
3636
default: all
3737
options:
3838
- release
3939
- nightly
4040
- test
4141
- all
42-
pull_request:
43-
paths:
44-
- .github/workflows/validate-nightly-binaries.yml
45-
- .github/workflows/validate-linux-binaries.yml
46-
- .github/workflows/validate-windows-binaries.yml
47-
- .github/workflows/validate-macos-binaries.yml
48-
- test/smoke_test/*
4942

5043
jobs:
5144
win:

.github/workflows/validate-nightly-binaries.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,13 @@ on:
1616
- .github/workflows/validate-windows-binaries.yml
1717
- .github/workflows/validate-macos-binaries.yml
1818
- test/smoke_test/*
19-
19+
pull_request:
20+
paths:
21+
- .github/workflows/validate-nightly-binaries.yml
22+
- .github/workflows/validate-linux-binaries.yml
23+
- .github/workflows/validate-windows-binaries.yml
24+
- .github/workflows/validate-macos-binaries.yml
25+
- test/smoke_test/*
2026

2127
jobs:
2228
nightly:

.github/workflows/validate-windows-binaries.yml

+15-42
Original file line numberDiff line numberDiff line change
@@ -22,29 +22,17 @@ on:
2222
- all
2323

2424
jobs:
25-
generate-windows-conda-matrix:
25+
generate-windows-matrix:
2626
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
2727
with:
28-
package-type: conda
29-
os: windows
30-
channel: ${{ inputs.channel }}
31-
generate-windows-wheel-matrix:
32-
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
33-
with:
34-
package-type: wheel
35-
os: windows
36-
channel: ${{ inputs.channel }}
37-
generate-windows-libtorch-matrix:
38-
uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
39-
with:
40-
package-type: libtorch
28+
package-type: all
4129
os: windows
4230
channel: ${{ inputs.channel }}
4331

44-
win-conda:
45-
needs: generate-windows-conda-matrix
32+
win:
33+
needs: generate-windows-matrix
4634
strategy:
47-
matrix: ${{ fromJson(needs.generate-windows-conda-matrix.outputs.matrix) }}
35+
matrix: ${{ fromJson(needs.generate-windows-matrix.outputs.matrix) }}
4836
fail-fast: false
4937
uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
5038
with:
@@ -57,29 +45,14 @@ jobs:
5745
export GPU_ARCH_VER="${{ matrix.gpu_arch_version }}"
5846
export GPU_ARCH_TYPE="${{ matrix.gpu_arch_type }}"
5947
export INSTALLATION="${{ matrix.installation }}"
60-
export CUDA_VER="${{ inputs.desired_cuda }}"
61-
conda create -y -n ${ENV_NAME} python=${{ matrix.python_version }} numpy pillow
62-
conda activate ${ENV_NAME}
63-
eval $INSTALLATION
64-
python ./test/smoke_test/smoke_test.py
48+
export CUDA_VER="${{ matrix.desired_cuda }}"
6549
66-
win-wheel:
67-
needs: generate-windows-wheel-matrix
68-
uses: ./.github/workflows/validate-windows-binary.yml
69-
name: win-wheel
70-
with:
71-
test-matrix: ${{ needs.generate-windows-wheel-matrix.outputs.matrix }}
72-
73-
win-libt:
74-
needs: generate-windows-libtorch-matrix
75-
strategy:
76-
matrix:
77-
${{ fromJson(needs.generate-windows-libtorch-matrix.outputs.matrix) }}
78-
fail-fast: false
79-
uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
80-
with:
81-
job-name: ${{ inputs.build_name }}
82-
script: |
83-
set -ex
84-
curl ${{ matrix.installation }} -o libtorch.zip
85-
unzip libtorch.zip
50+
if [[ ${{ matrix.package_type }} == "libtorch" ]]; then
51+
curl ${{ matrix.installation }} -o libtorch.zip
52+
unzip libtorch.zip
53+
else
54+
conda create -y -n ${ENV_NAME} python=${{ matrix.python_version }} numpy pillow
55+
conda activate ${ENV_NAME}
56+
eval $INSTALLATION
57+
python ./test/smoke_test/smoke_test.py
58+
fi

0 commit comments

Comments
 (0)