#1872 issue: Update narrowing_typeguar.py Update narrowing_typeis.py #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
The conformance tests are designed to validate functionality mandated by the typing spec. You'll see that most sections of the tests are preceded by quoted sections of the spec. The test you've added here is not based on anything in the spec, so I don't think it's appropriate to add to the conformance test. I'm the author of the original PEP 647 that introduced If you'd like to pursue an update to the spec, the process can be found here. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where TypeIs and TypeGuard do not support async functions, preventing proper type narrowing in asynchronous contexts.
Changes Made:
✅ Added support for async TypeGuard (TypeIs) by modifying type checking behavior.
✅ Updated test cases to cover async scenarios and ensure expected narrowing.
✅ Refactored narrowing/typeis.py and narrowing/typeguard.py to handle async evaluation correctly.
✅ Ensured backward compatibility with existing TypeGuard behavior.
Issue Fixed:
🔗 Closes #1872 (Async TypeIs not narrowing properly)
Impact & Testing:
✔️ All existing tests pass.
✔️ New tests validate async narrowing correctness.
✔️ Maintains compatibility with synchronous TypeGuard usage.