Skip to content

Commit 5e8b4f9

Browse files
Daniil KalininDaniil Kalinin
authored andcommitted
conformance: update the results after changes in dataclasses_inheritance.py
1 parent d11ce4d commit 5e8b4f9

File tree

7 files changed

+27
-17
lines changed

7 files changed

+27
-17
lines changed
Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
conformant = "Pass"
1+
conformant = "Partial"
2+
notes = """
3+
Does not report when the default value of dataclass field is mutable (is of type list, dict, or set).
4+
"""
25
output = """
36
dataclasses_inheritance.py:60: error: Cannot override instance variable (previously declared on base class "DC6") with class variable [misc]
47
dataclasses_inheritance.py:64: error: Cannot override class variable (previously declared on base class "DC6") with instance variable [misc]
58
"""
6-
conformance_automated = "Pass"
9+
conformance_automated = "Fail"
710
errors_diff = """
11+
Line 47: Expected 1 errors
812
"""

conformance/results/mypy/version.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
version = "mypy 1.16.0"
2-
test_duration = 1.7
2+
test_duration = 2.0
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
conformant = "Partial"
22
notes = """
3+
Does not report when the default value of dataclass field is mutable (is of type list, dict, or set).
34
Does not reject ClassVar that is overridden by instance variable.
45
Does not reject instance variable that is overridden by ClassVar.
56
"""
67
output = """
78
"""
89
conformance_automated = "Fail"
910
errors_diff = """
11+
Line 47: Expected 1 errors
1012
Line 60: Expected 1 errors
1113
Line 64: Expected 1 errors
1214
"""

conformance/results/pyre/version.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
version = "pyre 0.9.23"
2-
test_duration = 5.7
2+
test_duration = 9.1
Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1-
conformant = "Pass"
1+
conformant = "Partial"
2+
notes = """
3+
Does not report when the default value of dataclass field is mutable (is of type list, dict, or set).
4+
"""
25
output = """
36
dataclasses_inheritance.py:60:5 - error: Class variable "x" overrides instance variable of same name in class "DC6" (reportIncompatibleVariableOverride)
47
dataclasses_inheritance.py:64:5 - error: Instance variable "y" overrides class variable of same name in class "DC6" (reportIncompatibleVariableOverride)
58
"""
6-
conformance_automated = "Pass"
9+
conformance_automated = "Fail"
710
errors_diff = """
11+
Line 47: Expected 1 errors
812
"""
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
version = "pyright 1.1.401"
2-
test_duration = 1.1
2+
test_duration = 1.4

conformance/results/results.html

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -159,13 +159,13 @@ <h3>Python Type System Conformance Test Results</h3>
159159
<div class="table_container"><table><tbody>
160160
<tr><th class="col1">&nbsp;</th>
161161
<th class='tc-header'><div class='tc-name'>mypy 1.16.0</div>
162-
<div class='tc-time'>1.7sec</div>
162+
<div class='tc-time'>2.0sec</div>
163163
</th>
164164
<th class='tc-header'><div class='tc-name'>pyright 1.1.401</div>
165-
<div class='tc-time'>1.1sec</div>
165+
<div class='tc-time'>1.4sec</div>
166166
</th>
167167
<th class='tc-header'><div class='tc-name'>pyre 0.9.23</div>
168-
<div class='tc-time'>5.7sec</div>
168+
<div class='tc-time'>9.1sec</div>
169169
</th>
170170
</tr>
171171
<tr><th class="column" colspan="4">
@@ -353,7 +353,7 @@ <h3>Python Type System Conformance Test Results</h3>
353353
<th class="column col2 not-conformant"><div class="hover-text">Unsupported<span class="tooltip-text" id="bottom"><p>Does not support star expressions for `Unpack`.</p></span></div></th>
354354
</tr>
355355
<tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;generics_typevartuple_specialization</th>
356-
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Incorrectly specializes generic alias that includes a TypeVar and TypeVarTuple if no type arguments are provided.</p><p>Rejects specialization of generic type alias defined as a tuple containing a TypeVar.</p><p>"More than one Unpack" error message has no line number.</p></span></div></th>
356+
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Incorrectly specializes generic alias that includes a TypeVar and TypeVarTuple if no type arguments are provided.</p><p>Rejects specialization of generic type alias defined as a tuple containing a TypeVar.</p></span></div></th>
357357
<th class="column col2 conformant">Pass</th>
358358
<th class="column col2 not-conformant"><div class="hover-text">Unsupported<span class="tooltip-text" id="bottom"><p>Does not support star expressions for `Unpack`.</p></span></div></th>
359359
</tr>
@@ -404,7 +404,7 @@ <h3>Python Type System Conformance Test Results</h3>
404404
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not reject use of TypeVar in ClassVar.</p><p>Does not reject use of ParamSpec in ClassVar.</p><p>Does not reject use of ClassVar as a generic type argument.</p><p>Does not reject use of ClassVar in parameter type annotation.</p><p>Does not reject use of ClassVar in local variable annotation.</p><p>Does not reject use of ClassVar in instance variable annotation.</p><p>Does not reject use of ClassVar in return type annotation.</p><p>Does not reject use of ClassVar in type alias definition.</p><p>Does not infer type from initialization for bare ClassVar.</p></span></div></th>
405405
</tr>
406406
<tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;classes_override</th>
407-
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not handle case where parent class derives from Any.</p></span></div></th>
407+
<th class="column col2 conformant">Pass</th>
408408
<th class="column col2 conformant">Pass</th>
409409
<th class="column col2 conformant">Pass</th>
410410
</tr>
@@ -597,7 +597,7 @@ <h3>Python Type System Conformance Test Results</h3>
597597
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not apply decorator transforms before checking overload consistency.</p></span></div></th>
598598
</tr>
599599
<tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;overloads_definitions</th>
600-
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not allow an overload with no implementation in an abstract base class.</p><p>Allows @override to be on all overloads and implementation, instead of just implementation.</p></span></div></th>
600+
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Allows @override to be on all overloads and implementation, instead of just implementation.</p></span></div></th>
601601
<th class="column col2 conformant">Pass</th>
602602
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not allow an overload with no implementation in a Protocol or an abstract base class.</p><p>Expects @final/@override on all overloads and implementation, instead of implementation only.</p></span></div></th>
603603
</tr>
@@ -643,9 +643,9 @@ <h3>Python Type System Conformance Test Results</h3>
643643
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not report when dataclass is not compatible with Hashable protocol.</p></span></div></th>
644644
</tr>
645645
<tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;dataclasses_inheritance</th>
646-
<th class="column col2 conformant">Pass</th>
647-
<th class="column col2 conformant">Pass</th>
648-
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not reject ClassVar that is overridden by instance variable.</p><p>Does not reject instance variable that is overridden by ClassVar.</p></span></div></th>
646+
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not report when the default value of dataclass field is mutable (is of type list, dict, or set).</p></span></div></th>
647+
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not report when the default value of dataclass field is mutable (is of type list, dict, or set).</p></span></div></th>
648+
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Does not report when the default value of dataclass field is mutable (is of type list, dict, or set).</p><p>Does not reject ClassVar that is overridden by instance variable.</p><p>Does not reject instance variable that is overridden by ClassVar.</p></span></div></th>
649649
</tr>
650650
<tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;dataclasses_kwonly</th>
651651
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>Incorrectly rejects kw_only field with default before positional field.</p></span></div></th>
@@ -779,7 +779,7 @@ <h3>Python Type System Conformance Test Results</h3>
779779
<th class="column col2 conformant">Pass</th>
780780
</tr>
781781
<tr><th class="column col1">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;tuples_unpacked</th>
782-
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>"More than one unpack" error is missing a line number.</p></span></div></th>
782+
<th class="column col2 partially-conformant"><div class="hover-text">Partial<span class="tooltip-text" id="bottom"><p>"More than one unpack" error is missing in some cases.</p></span></div></th>
783783
<th class="column col2 conformant">Pass</th>
784784
<th class="column col2 conformant">Pass</th>
785785
</tr>

0 commit comments

Comments
 (0)