Skip to content

Commit 665b8f3

Browse files
authored
gh-113655: Revert extra stack reserve in PGO builds unless UseExtraStackReserve=true (GH-114263)
1 parent 412920a commit 665b8f3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

PCbuild/python.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
<StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize>
100100
<StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize>
101101
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed -->
102-
<StackReserveSize Condition="$(Configuration) == 'PGUpdate'">3000000</StackReserveSize>
102+
<StackReserveSize Condition="$(Configuration) == 'PGUpdate' and $(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
103103
</Link>
104104
</ItemDefinitionGroup>
105105
<ItemGroup>

PCbuild/pythonw.vcxproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
<StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize>
9595
<StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize>
9696
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed -->
97-
<StackReserveSize Condition="$(Configuration) == 'PGUpdate'">3000000</StackReserveSize>
97+
<StackReserveSize Condition="$(Configuration) == 'PGUpdate' and $(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
9898
</Link>
9999
</ItemDefinitionGroup>
100100
<ItemGroup>

0 commit comments

Comments
 (0)