Skip to content

Commit 37eab55

Browse files
authored
bpo-46387: test all pickle protos in test_field_descriptor in test_collections (GH-30614)
1 parent 0a28118 commit 37eab55

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

Lib/test/test_collections.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -677,14 +677,16 @@ def test_field_descriptor(self):
677677
self.assertRaises(AttributeError, Point.x.__set__, p, 33)
678678
self.assertRaises(AttributeError, Point.x.__delete__, p)
679679

680-
class NewPoint(tuple):
681-
x = pickle.loads(pickle.dumps(Point.x))
682-
y = pickle.loads(pickle.dumps(Point.y))
680+
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
681+
with self.subTest(proto=proto):
682+
class NewPoint(tuple):
683+
x = pickle.loads(pickle.dumps(Point.x, proto))
684+
y = pickle.loads(pickle.dumps(Point.y, proto))
683685

684-
np = NewPoint([1, 2])
686+
np = NewPoint([1, 2])
685687

686-
self.assertEqual(np.x, 1)
687-
self.assertEqual(np.y, 2)
688+
self.assertEqual(np.x, 1)
689+
self.assertEqual(np.y, 2)
688690

689691
def test_new_builtins_issue_43102(self):
690692
obj = namedtuple('C', ())

0 commit comments

Comments
 (0)