Add type-local type cache

Author: DinoV

Include/cpython/object.h

@@ -259,6 +259,9 @@ struct _specialization_cache {
     PyObject *getitem;
     uint32_t getitem_version;
     PyObject *init;
+#ifdef Py_GIL_DISABLED
+    struct local_type_cache *local_type_cache;
+#endif
 };
 
 /* The *real* layout of a type object when allocated on the heap */

Include/internal/pycore_typeobject.h

@@ -71,6 +71,28 @@ struct type_cache {
     struct type_cache_entry hashtable[1 << MCACHE_SIZE_EXP];
 };
 
+#ifdef Py_GIL_DISABLED
+
+// Type attribute lookup cache which is type-specific. Only used
+// for heap types where we store a small additional cache in free-threaded
+// builds which can be accessed without any locking.
+#define LOCAL_TYPE_CACHE_SIZE 32
+#define LOCAL_TYPE_CACHE_MAX_ENTRIES 24
+#define LOCAL_TYPE_CACHE_PROBE 3
+
+struct local_type_cache_entry {
+    PyObject *name;     // reference to exactly a str or NULL
+    PyObject *value;    // owned reference or NULL
+};
+
+struct local_type_cache {
+    unsigned int tp_version_tag;
+    unsigned int cache_count;
+    struct local_type_cache_entry entries[LOCAL_TYPE_CACHE_SIZE];
+};
+
+#endif
+
 typedef struct {
     PyTypeObject *type;
     int isbuiltin;
@@ -85,6 +107,9 @@ typedef struct {
        are also some diagnostic uses for the list of weakrefs,
        so we still keep it. */
     PyObject *tp_weaklist;
+#ifdef Py_GIL_DISABLED
+    struct local_type_cache local_cache;
+#endif
 } managed_static_type_state;
 
 #define TYPE_VERSION_CACHE_SIZE (1<<12)  /* Must be a power of 2 */

Lib/test/test_sys.py

@@ -1731,6 +1731,7 @@ def delx(self): del self.__x
         s = vsize(fmt)
         check(int, s)
         typeid = 'n' if support.Py_GIL_DISABLED else ''
+        local_type_cache = 'P' if support.Py_GIL_DISABLED else ''
         # class
         s = vsize(fmt +                 # PyTypeObject
                   '4P'                  # PyAsyncMethods
@@ -1741,6 +1742,7 @@ def delx(self): del self.__x
                   '7P'
                   '1PIP'                # Specializer cache
                   + typeid              # heap type id (free-threaded only)
+                  + local_type_cache    # local type cache (free-threaded only)
                   )
         class newstyleclass(object): pass
         # Separate block for PyDictKeysObject with 8 keys and 5 entries

Objects/typeobject.c

@@ -255,6 +255,9 @@ managed_static_type_state_init(PyInterpreterState *interp, PyTypeObject *self,
     assert(state->type == NULL);
     state->type = self;
     state->isbuiltin = isbuiltin;
+#ifdef Py_GIL_DISABLED
+    state->local_cache.tp_version_tag = self->tp_version_tag;
+#endif
 
     /* state->tp_subclasses is left NULL until init_subclasses() sets it. */
     /* state->tp_weaklist is left NULL until insert_head() or insert_after()
@@ -290,6 +293,12 @@ managed_static_type_state_clear(PyInterpreterState *interp, PyTypeObject *self,
     assert(state->type != NULL);
     state->type = NULL;
     assert(state->tp_weaklist == NULL);  // It was already cleared out.
+#ifdef Py_GIL_DISABLED
+    for (Py_ssize_t i = 0; i<LOCAL_TYPE_CACHE_SIZE; i++) {
+        Py_CLEAR(state->local_cache.entries[i].name);
+        state->local_cache.entries[i].value = NULL;
+    }
+#endif
 
     (void)_Py_atomic_add_int64(
             &_PyRuntime.types.managed_static.types[full_index].interp_count, -1);
@@ -1021,6 +1030,36 @@ set_version_unlocked(PyTypeObject *tp, unsigned int version)
 #endif
 }
 
+static void
+clear_spec_cache(PyTypeObject *type)
+{
+    if (PyType_HasFeature(type, Py_TPFLAGS_HEAPTYPE)) {
+        // This field *must* be invalidated if the type is modified (see the
+        // comment on struct _specialization_cache):
+        PyHeapTypeObject *heap_type = (PyHeapTypeObject *)type;
+        FT_ATOMIC_STORE_PTR_RELAXED(
+            heap_type->_spec_cache.getitem, NULL);
+#ifdef Py_GIL_DISABLED
+        struct local_type_cache *cache = heap_type->_spec_cache.local_type_cache;
+        if (cache != NULL) {
+            FT_ATOMIC_STORE_PTR_RELAXED(
+                heap_type->_spec_cache.local_type_cache, NULL);
+            for (Py_ssize_t i = 0; i<LOCAL_TYPE_CACHE_SIZE; i++) {
+                PyObject *name = _Py_atomic_load_ptr_relaxed(&cache->entries[i].name);
+                if (name != NULL) {
+                    // Readers can be racing with the local type cache when a value is being replaced
+                    // in the type, and they can try and incref it after it has been decref'd, so
+                    // we eagerly clear these out.
+                    _Py_atomic_store_ptr_release(&cache->entries[i].name, NULL);
+                    Py_DECREF(name);
+                }
+            }
+            _PyMem_FreeDelayed(cache);
+        }
+#endif
+    }
+}
+
 static void
 type_modified_unlocked(PyTypeObject *type)
 {
@@ -1083,12 +1122,7 @@ type_modified_unlocked(PyTypeObject *type)
     }
 
     set_version_unlocked(type, 0); /* 0 is not a valid version tag */
-    if (PyType_HasFeature(type, Py_TPFLAGS_HEAPTYPE)) {
-        // This field *must* be invalidated if the type is modified (see the
-        // comment on struct _specialization_cache):
-        FT_ATOMIC_STORE_PTR_RELAXED(
-            ((PyHeapTypeObject *)type)->_spec_cache.getitem, NULL);
-    }
+    clear_spec_cache(type);
 }
 
 void
@@ -1165,12 +1199,7 @@ type_mro_modified(PyTypeObject *type, PyObject *bases) {
     assert(!(type->tp_flags & _Py_TPFLAGS_STATIC_BUILTIN));
     set_version_unlocked(type, 0);  /* 0 is not a valid version tag */
     type->tp_versions_used = _Py_ATTR_CACHE_UNUSED;
-    if (PyType_HasFeature(type, Py_TPFLAGS_HEAPTYPE)) {
-        // This field *must* be invalidated if the type is modified (see the
-        // comment on struct _specialization_cache):
-        FT_ATOMIC_STORE_PTR_RELAXED(
-            ((PyHeapTypeObject *)type)->_spec_cache.getitem, NULL);
-    }
+    clear_spec_cache(type);
 }
 
 /*
@@ -5542,6 +5571,119 @@ _PyTypes_AfterFork(void)
 #endif
 }
 
+#ifdef Py_GIL_DISABLED
+
+static bool
+can_cache_locally(PyTypeObject *type, PyObject *name) {
+    // We don't cache types in l1 for anything which is a custom get attr, it's likely
+    // to have many dynamic attributes (think modules and metaclasses).
+    // We also only cache interned or immortal strings.
+    return type->tp_getattro == PyObject_GenericGetAttr &&
+           (PyUnicode_CHECK_INTERNED(name) != SSTATE_NOT_INTERNED || _Py_IsImmortal(name));
+}
+
+static struct local_type_cache *
+get_local_type_cache(PyTypeObject *type, unsigned int assigned_version)
+{
+    unsigned long flags = FT_ATOMIC_LOAD_ULONG_RELAXED(type->tp_flags);
+
+    if (flags & Py_TPFLAGS_HEAPTYPE) {
+        PyHeapTypeObject *heap_type = (PyHeapTypeObject *)type;
+        struct local_type_cache *local_cache = _Py_atomic_load_ptr_acquire(&heap_type->_spec_cache.local_type_cache);
+        if (local_cache == NULL && assigned_version) {
+            local_cache = PyMem_Calloc(1, sizeof(struct local_type_cache));
+            local_cache->tp_version_tag = assigned_version;
+            _Py_atomic_store_ptr_release(&heap_type->_spec_cache.local_type_cache, local_cache);
+        }
+        return local_cache;
+    } else if (flags & _Py_TPFLAGS_STATIC_BUILTIN) {
+        PyInterpreterState *interp = _PyInterpreterState_GET();
+        managed_static_type_state *state = managed_static_type_state_get(interp, type);
+        return &state->local_cache;
+    }
+    return NULL;
+}
+
+#define HASH_NAME(name) (((Py_ssize_t)(name)) >> LOCAL_TYPE_CACHE_PROBE)
+
+static bool
+try_local_cache_lookup(PyTypeObject *type, PyObject *name, PyObject **value, unsigned int *version)
+{
+    if (!can_cache_locally(type, name)) {
+        return false;
+    }
+
+    struct local_type_cache *local_cache = get_local_type_cache(type, 0);
+    if (local_cache == NULL) {
+        return false;
+    }
+
+    Py_ssize_t index = HASH_NAME(name) % LOCAL_TYPE_CACHE_SIZE;
+    Py_ssize_t cur = index;
+    do {
+        struct local_type_cache_entry *entry = &local_cache->entries[cur];
+        PyObject *entry_name = _Py_atomic_load_ptr_acquire(&entry->name);
+        if (entry_name == name) {
+            // Value is set as maybe weakref'd, and the per-type cache never replaces
+            // values so we get away w/ a simple incref here.
+            PyObject *entry_value = _Py_atomic_load_ptr_relaxed(&entry->value);
+            Py_XINCREF(entry_value);
+            *value = entry_value;
+
+            if (version) {
+                *version = local_cache->tp_version_tag;
+            }
+
+            return true;
+        }
+        else if (entry_name == NULL) {
+            break;
+        }
+        cur = (cur + LOCAL_TYPE_CACHE_PROBE) % LOCAL_TYPE_CACHE_SIZE;
+    } while(cur != index);
+    return false;
+}
+
+static bool
+cache_local_type_lookup(PyTypeObject *type, PyObject *name,
+                        PyObject *res, unsigned int assigned_version)
+{
+    if (!can_cache_locally(type, name) ||
+        type->tp_versions_used >= MAX_VERSIONS_PER_CLASS) {
+        return false;
+    }
+
+    struct local_type_cache *local_cache = get_local_type_cache(type, assigned_version);
+    if (local_cache == NULL ||
+        local_cache->cache_count >= LOCAL_TYPE_CACHE_MAX_ENTRIES) {
+        return false;
+    }
+
+    Py_ssize_t index = HASH_NAME(name) % LOCAL_TYPE_CACHE_SIZE;
+    Py_ssize_t cur = index;
+    do {
+        struct local_type_cache_entry *entry = &local_cache->entries[cur];
+        PyObject *entry_name = _Py_atomic_load_ptr_relaxed(&entry->name);
+        if (entry_name == NULL) {
+            if (res != NULL) {
+                // Reads from other threads can proceed lock-free.
+                _PyObject_SetMaybeWeakref(res);
+            }
+
+            // Value is written first, then name, so when name is read the
+            // value is always present.
+            _Py_atomic_store_ptr_relaxed(&entry->value, res);
+            _Py_atomic_store_ptr_release(&entry->name, Py_NewRef(name));
+            local_cache->cache_count++;
+            return true;
+        }
+        cur = (cur + LOCAL_TYPE_CACHE_PROBE) % LOCAL_TYPE_CACHE_SIZE;
+    } while (cur != index);
+    return false;
+}
+
+#endif
+
 /* Internal API to look for a name through the MRO.
    This returns a strong reference, and doesn't set an exception!
    If nonzero, version is set to the value of type->tp_version at the time of
@@ -5551,13 +5693,22 @@ PyObject *
 _PyType_LookupRefAndVersion(PyTypeObject *type, PyObject *name, unsigned int *version)
 {
     PyObject *res;
+
+#ifdef Py_GIL_DISABLED
+    // Free-threaded, try a completely lock-free per-type L1 cache first
+    if (try_local_cache_lookup(type, name, &res, version)) {
+        return res;
+    }
+#endif
+
     int error;
     PyInterpreterState *interp = _PyInterpreterState_GET();
-
     unsigned int h = MCACHE_HASH_METHOD(type, name);
     struct type_cache *cache = get_type_cache();
     struct type_cache_entry *entry = &cache->hashtable[h];
+
 #ifdef Py_GIL_DISABLED
+    // Fall back to global L2 cache which requires sequence locks
     // synchronize-with other writing threads by doing an acquire load on the sequence
     while (1) {
         uint32_t sequence = _PySeqLock_BeginRead(&entry->sequence);
@@ -5574,6 +5725,7 @@ _PyType_LookupRefAndVersion(PyTypeObject *type, PyObject *name, unsigned int *ve
                     if (version != NULL) {
                         *version = entry_version;
                     }
+
                     return value;
                 }
                 Py_XDECREF(value);
@@ -5612,12 +5764,20 @@ _PyType_LookupRefAndVersion(PyTypeObject *type, PyObject *name, unsigned int *ve
 
     int has_version = 0;
     unsigned int assigned_version = 0;
+
+    bool locally_cached = false;
     BEGIN_TYPE_LOCK();
+
     res = find_name_in_mro(type, name, &error);
     if (MCACHE_CACHEABLE_NAME(name)) {
         has_version = assign_version_tag(interp, type);
         assigned_version = type->tp_version_tag;
     }
+
+#ifdef Py_GIL_DISABLED
+    locally_cached = has_version && !error &&
+                     cache_local_type_lookup(type, name, res, assigned_version);
+#endif
     END_TYPE_LOCK();
 
     /* Only put NULL results into cache if there was no error. */
@@ -5640,9 +5800,10 @@ _PyType_LookupRefAndVersion(PyTypeObject *type, PyObject *name, unsigned int *ve
         return NULL;
     }
 
-    if (has_version) {
+    if (has_version && !locally_cached) {
 #if Py_GIL_DISABLED
         update_cache_gil_disabled(entry, name, assigned_version, res);
+
 #else
         PyObject *old_value = update_cache(entry, name, assigned_version, res);
         Py_DECREF(old_value);
@@ -6164,6 +6325,7 @@ type_dealloc(PyObject *self)
     }
     Py_XDECREF(et->ht_module);
     PyMem_Free(et->_ht_tpname);
+    clear_spec_cache(type);
 #ifdef Py_GIL_DISABLED
     assert(et->unique_id == _Py_INVALID_UNIQUE_ID);
 #endif