Skip to content

Exif: MakerNote enums spelled differently #8614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mixmastamyk opened this issue Dec 21, 2024 · 3 comments · Fixed by #8615
Closed

Exif: MakerNote enums spelled differently #8614

mixmastamyk opened this issue Dec 21, 2024 · 3 comments · Fixed by #8615
Labels

Comments

@mixmastamyk
Copy link
Contributor

mixmastamyk commented Dec 21, 2024

https://github.com/python-pillow/Pillow/blob/main/src/PIL/ExifTags.py#L156

MakerNote = 0x927C

https://github.com/python-pillow/Pillow/blob/main/src/PIL/ExifTags.py#L355

Makernote = 37500

These names should be consistent. Also, some values specified in hex and others in decimal is a bit messy, though merely cosmetic.

@mixmastamyk mixmastamyk changed the title MakerNote enums spelled differently Exif: MakerNote enums spelled differently Dec 21, 2024
@radarhere
Copy link
Member

I've created #8615 to resolve this.

Also, just as an aside - you've linked to my fork, rather than to this repository.

@mixmastamyk
Copy link
Contributor Author

Thanks. However, it would probably be good to carry the old spelling for a while, marked deprecated as a courtesy. Otherwise will break some users. Unless there is a big breaking release coming up.

@radarhere
Copy link
Member

I've created #8629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants