Skip to content

Remove outdated warning about faulthandler_timeout on Windows #13492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Iwithyou2025
Copy link
Contributor

This PR removes the outdated warning regarding faulthandler_timeout on Windows as suggested in issue #13456.

The option is now functional on Windows, so the "(not available on Windows)" note has been removed from the documentation (failures.rst).

@The-Compiler The-Compiler added type: docs documentation improvement, missing or needing clarification backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch labels Jun 6, 2025
@The-Compiler
Copy link
Member

Any opinions on whether this needs a changelog entry? It's a trivial fix, but on the other hand a changelog entry would notify people that might have been holding off the feature that they can actually start using it.

@nicoddemus
Copy link
Member

It's a trivial fix, but on the other hand a changelog entry would notify people that might have been holding off the feature that they can actually start using it.

Sure! We have added changelog entries in the past for things much less impactful than this.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Jun 6, 2025
@nicoddemus nicoddemus enabled auto-merge (squash) June 6, 2025 12:20
@nicoddemus nicoddemus merged commit 216c7ec into pytest-dev:main Jun 6, 2025
31 checks passed
Copy link

patchback bot commented Jun 6, 2025

Backport to 8.4.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.4.x/216c7ec882b2aa30fb8a35e100c990c34fca12c1/pr-13492

Backported as #13493

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 6, 2025
---------

Co-authored-by: Bruno Oliveira <[email protected]>
(cherry picked from commit 216c7ec)
nicoddemus added a commit that referenced this pull request Jun 6, 2025
#13493)

---------


(cherry picked from commit 216c7ec)

Co-authored-by: Iwithyou2025 <[email protected]>
Co-authored-by: Bruno Oliveira <[email protected]>
@Iwithyou2025 Iwithyou2025 deleted the fix-doc-faulthandler-warning branch July 12, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.4.x apply to PRs at any point; backports the changes to the 8.4.x branch bot:chronographer:provided (automation) changelog entry is part of PR type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants