Simplified test case.

Also improved package check logic to be locales agnostic.

Author: narmaku

test/test_modules.py

@@ -58,19 +58,16 @@ def test_held_package(host):
     assert python.is_installed
     assert python.version.startswith("3.11.")
 
-@pytest.mark.destructive
 @pytest.mark.testinfra_hosts("docker://rockylinux9")
-def test_rpm_package_broken_db(host):
-    with host.sudo():
-        # Corrupt RPM database so that we make RpmPackage.is_installed throw an exception
-        host.run_test('rpm --rebuilddb')
-        host.run_test('dd if=/dev/zero of=$(rpm --dbpath)/Packages bs=1024 count=1024 seek=1024')
+def test_rpm_package_not_installed(host):
+    # Pass an invalid value as package name, it returns exit code 1
+    pkg_name = "-3"
     with pytest.raises(RuntimeError) as excinfo:
-        host.package("zsh").is_installed
+        host.package(pkg_name).is_installed
     assert (
-        "DB_PAGE_NOT_FOUND"
-        in str(excinfo.value)
-    )
+        f"Could not check if RPM package '{pkg_name}' is installed. "
+        f"rpm: {pkg_name}: unknown option"
+    ) in str(excinfo.value)
 
 @pytest.mark.testinfra_hosts("docker://rockylinux9")
 def test_non_default_package_tool(host):

testinfra/modules/package.py

@@ -165,14 +165,13 @@ def version(self):
 class RpmPackage(Package):
     @property
     def is_installed(self):
-        result = self.run("rpm -q %s", self.name)
+        result = self.run("rpm -q --quiet %s 2>&1", self.name)
         if result.succeeded:
             return True
-
-        if "not installed" in result.stdout or not result.stdout.startswith(self.name):
+        elif result.failed and result.stdout == '':
             return False
-
-        raise RuntimeError(f"Could not check if RPM package '{self.name}' is installed. {result}")
+        else:
+            raise RuntimeError(f"Could not check if RPM package '{self.name}' is installed. {result.stdout}")
 
     @property
     def version(self):