Skip to content

Commit 295d395

Browse files
committed
Close tempfile in tests to avoid warnings
1 parent 04ce95c commit 295d395

File tree

3 files changed

+20
-3
lines changed

3 files changed

+20
-3
lines changed

CHANGES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ The released versions correspond to PyPI releases.
1313
the real filesystem behavior
1414
* remove support for Python versions before 3.10 (if needed, patches may be backported to the 5.x branch)
1515

16+
## Unreleased
17+
18+
### Infrastructure
19+
* fixed some warnings in tests (see [#1190](../../issues/1190))
20+
1621
## [Version 5.9.1](https://pypi.python.org/pypi/pyfakefs/5.9.1) (2025-06-23)
1722
Fixes regression in packaging in version 5.9.0.
1823

pyfakefs/tests/fake_filesystem_unittest_test.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -586,6 +586,9 @@ def test_pause_resume(self):
586586
self.resume()
587587
self.assertFalse(os.path.exists(real_temp_file.name))
588588
self.assertTrue(os.path.exists(fake_temp_file.name))
589+
self.pause()
590+
real_temp_file.close()
591+
self.resume()
589592

590593
def test_pause_resume_fs(self):
591594
fake_temp_file = tempfile.NamedTemporaryFile()
@@ -607,6 +610,9 @@ def test_pause_resume_fs(self):
607610
self.fs.resume()
608611
self.assertFalse(os.path.exists(real_temp_file.name))
609612
self.assertTrue(os.path.exists(fake_temp_file.name))
613+
self.fs.pause()
614+
real_temp_file.close()
615+
self.fs.resume()
610616

611617
def test_pause_resume_contextmanager(self):
612618
fake_temp_file = tempfile.NamedTemporaryFile()
@@ -618,6 +624,7 @@ def test_pause_resume_contextmanager(self):
618624
real_temp_file = tempfile.NamedTemporaryFile()
619625
self.assertFalse(self.fs.exists(real_temp_file.name))
620626
self.assertTrue(os.path.exists(real_temp_file.name))
627+
real_temp_file.close()
621628
self.assertFalse(os.path.exists(real_temp_file.name))
622629
self.assertTrue(os.path.exists(fake_temp_file.name))
623630

@@ -631,6 +638,7 @@ def test_pause_resume_fs_contextmanager(self):
631638
real_temp_file = tempfile.NamedTemporaryFile()
632639
self.assertFalse(self.fs.exists(real_temp_file.name))
633640
self.assertTrue(os.path.exists(real_temp_file.name))
641+
real_temp_file.close()
634642
self.assertFalse(os.path.exists(real_temp_file.name))
635643
self.assertTrue(os.path.exists(fake_temp_file.name))
636644

@@ -662,7 +670,10 @@ def test_pause_resume(self):
662670
p.resume()
663671
self.assertFalse(os.path.exists(real_temp_file.name))
664672
self.assertTrue(os.path.exists(fake_temp_file.name))
665-
real_temp_file.close()
673+
fake_temp_file.close()
674+
p.pause()
675+
real_temp_file.close()
676+
p.resume()
666677

667678
def test_pause_resume_contextmanager(self):
668679
with Patcher() as p:
@@ -675,9 +686,10 @@ def test_pause_resume_contextmanager(self):
675686
real_temp_file = tempfile.NamedTemporaryFile()
676687
self.assertFalse(p.fs.exists(real_temp_file.name))
677688
self.assertTrue(os.path.exists(real_temp_file.name))
689+
real_temp_file.close()
678690
self.assertFalse(os.path.exists(real_temp_file.name))
679691
self.assertTrue(os.path.exists(fake_temp_file.name))
680-
real_temp_file.close()
692+
fake_temp_file.close()
681693

682694

683695
class TestPyfakefsTestCase(unittest.TestCase):

pyfakefs/tests/skipped_pathlib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919

2020
def read_pathlib(file_name):
21-
return (Path(__file__).parent / file_name).open("r").read()
21+
return (Path(__file__).parent / file_name).open("r", encoding="utf8").read()
2222

2323

2424
def read_text_pathlib(file_name):

0 commit comments

Comments
 (0)