Update golangci-lint and fix issues

Author: metalmatze

.github/workflows/golangci-lint.yml

@@ -20,4 +20,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/[email protected]
         with:
-          version: v1.45
+          version: v1.49

filesystem.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"net/http"
 	"os"
@@ -31,8 +30,6 @@ import (
 	"github.com/pyrra-dev/pyrra/slo"
 )
 
-var errEndpointNotImplemented = errors.New("endpoint not implement")
-
 type Objectives struct {
 	mu         sync.RWMutex
 	objectives map[string]slo.Objective

kubernetes_test.go

@@ -2,19 +2,19 @@ package main
 
 import (
 	"context"
-	"github.com/bufbuild/connect-go"
-	objectivesv1alpha1 "github.com/pyrra-dev/pyrra/proto/objectives/v1alpha1"
-	"google.golang.org/protobuf/types/known/durationpb"
 	"testing"
 	"time"
 
+	"github.com/bufbuild/connect-go"
 	"github.com/prometheus/prometheus/model/labels"
 	"github.com/stretchr/testify/require"
+	"google.golang.org/protobuf/types/known/durationpb"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/yaml"
 
 	pyrrav1alpha1 "github.com/pyrra-dev/pyrra/kubernetes/api/v1alpha1"
+	objectivesv1alpha1 "github.com/pyrra-dev/pyrra/proto/objectives/v1alpha1"
 )
 
 var (

main.go

@@ -5,8 +5,8 @@ import (
 	"embed"
 	"fmt"
 	"html/template"
+	"io"
 	"io/fs"
-	"io/ioutil"
 	"math"
 	"net/http"
 	"net/url"
@@ -259,7 +259,7 @@ func (c *thanosClient) Do(ctx context.Context, r *http.Request) (*http.Response,
 	if r.Body == nil {
 		return c.client.Do(ctx, r)
 	}
-	body, err := ioutil.ReadAll(r.Body)
+	body, err := io.ReadAll(r.Body)
 	if err != nil {
 		return nil, nil, fmt.Errorf("reading body: %w", err)
 	}
@@ -292,7 +292,7 @@ func (c *thanosClient) Do(ctx context.Context, r *http.Request) (*http.Response,
 	}
 
 	encoded := query.Encode()
-	r.Body = ioutil.NopCloser(strings.NewReader(encoded))
+	r.Body = io.NopCloser(strings.NewReader(encoded))
 	return c.client.Do(ctx, r)
 }
 

main_test.go

@@ -1,16 +1,17 @@
 package main
 
 import (
-	objectivesv1alpha1 "github.com/pyrra-dev/pyrra/proto/objectives/v1alpha1"
-	"google.golang.org/protobuf/types/known/durationpb"
 	"math"
 	"testing"
 	"time"
 
 	"github.com/prometheus/common/model"
 	"github.com/prometheus/prometheus/model/labels"
-	"github.com/pyrra-dev/pyrra/slo"
 	"github.com/stretchr/testify/require"
+	"google.golang.org/protobuf/types/known/durationpb"
+
+	objectivesv1alpha1 "github.com/pyrra-dev/pyrra/proto/objectives/v1alpha1"
+	"github.com/pyrra-dev/pyrra/slo"
 )
 
 func TestMatrixToValues(t *testing.T) {