fix linting issues

Author: msvechla

kubernetes/controllers/servicelevelobjective.go

@@ -73,7 +73,6 @@ func (r *ServiceLevelObjectiveReconciler) Reconcile(ctx context.Context, req ctr
 	}
 
 	if r.MimirClient != nil {
-
 		mimirFinalizer := "mimir.servicelevelobjective.pyrra.dev/finalizer"
 		if slo.ObjectMeta.DeletionTimestamp.IsZero() {
 			// slo is not being deleted, add our finalizer if not already present
@@ -284,7 +283,7 @@ func makeConfigMap(name string, kubeObjective pyrrav1alpha1.ServiceLevelObjectiv
 	}, nil
 }
 
-func makeMimirRuleGroup(kubeObjective pyrrav1alpha1.ServiceLevelObjective, genericRules bool, writeAlertingRules bool) (*rulefmt.RuleGroup, error) {
+func makeMimirRuleGroup(kubeObjective pyrrav1alpha1.ServiceLevelObjective, genericRules, writeAlertingRules bool) (*rulefmt.RuleGroup, error) {
 	objective, err := kubeObjective.Internal()
 	if err != nil {
 		return nil, fmt.Errorf("failed to get objective: %w", err)

mimir/client.go

@@ -8,22 +8,22 @@ import (
 	"net/url"
 )
 
-// Client is a simple client for the required Mimir API resources
+// Client is a simple client for the required Mimir API resources.
 type Client struct {
 	client           http.Client
 	address          *url.URL
 	prometheusPrefix string
 }
 
-// Config is used to configure the client
+// Config is used to configure the client.
 type Config struct {
 	Address           string
 	PrometheusPrefix  string
 	BasicAuthUsername string
 	BasicAuthPassword string
 }
 
-// NewClient creates a new client with the given configuration
+// NewClient creates a new client with the given configuration.
 func NewClient(config Config) (*Client, error) {
 	addr, err := url.Parse(config.Address)
 	if err != nil {
@@ -51,20 +51,20 @@ func NewClient(config Config) (*Client, error) {
 	}, nil
 }
 
-// BasicAuthTransport is a transport that adds basic auth to the request
+// BasicAuthTransport is a transport that adds basic auth to the request.
 type BasicAuthTransport struct {
 	Username  string
 	Password  string
 	Transport http.RoundTripper
 }
 
-// RoundTrip adds basic auth to the request
+// RoundTrip adds basic auth to the request.
 func (t *BasicAuthTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 	req.SetBasicAuth(t.Username, t.Password)
 	return t.Transport.RoundTrip(req)
 }
 
-// Ready checks if mimir is ready to serve traffic
+// Ready checks if mimir is ready to serve traffic.
 func (c *Client) Ready(ctx context.Context) error {
 	path := c.address.JoinPath("/ready")
 

mimir/rulegroup.go

@@ -11,7 +11,7 @@ import (
 	"gopkg.in/yaml.v3"
 )
 
-// SetRuleGroup creates or updates a rule group
+// SetRuleGroup creates or updates a rule group.
 func (c *Client) SetRuleGroup(ctx context.Context, namespace string, ruleGroup rulefmt.RuleGroup) error {
 	path := c.address.JoinPath(c.prometheusPrefix, "/config/v1/rules/", namespace)
 
@@ -40,7 +40,7 @@ func (c *Client) SetRuleGroup(ctx context.Context, namespace string, ruleGroup r
 	return nil
 }
 
-// DeleteNamespace deletes all the rule groups in a namespace (including the namespace itself)
+// DeleteNamespace deletes all the rule groups in a namespace (including the namespace itself).
 func (c *Client) DeleteNamespace(ctx context.Context, namespace string) error {
 	path := c.address.JoinPath(c.prometheusPrefix, "/config/v1/rules/", namespace)