Skip to content

Commit 5fe176a

Browse files
committed
fix(SLOs): Use the 5.0 bucket by default
1 parent f9a0a4b commit 5fe176a

7 files changed

+35
-30
lines changed

examples/kubernetes/manifests-webhook/slos/slo-apiserver-read-cluster-latency.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
indicator:
1212
latency:
1313
success:
14-
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5"}
14+
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5.0"}
1515
total:
1616
metric: apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"cluster|",verb=~"LIST|GET"}
1717
target: "99"

examples/kubernetes/manifests-webhook/slos/slo-apiserver-read-namespace-latency.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
indicator:
1212
latency:
1313
success:
14-
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5"}
14+
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5.0"}
1515
total:
1616
metric: apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"namespace|",verb=~"LIST|GET"}
1717
target: "99"

examples/kubernetes/manifests/slos/slo-apiserver-read-cluster-latency.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
indicator:
1212
latency:
1313
success:
14-
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5"}
14+
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5.0"}
1515
total:
1616
metric: apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"cluster|",verb=~"LIST|GET"}
1717
target: "99"

examples/kubernetes/manifests/slos/slo-apiserver-read-namespace-latency.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
indicator:
1212
latency:
1313
success:
14-
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5"}
14+
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5.0"}
1515
total:
1616
metric: apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"namespace|",verb=~"LIST|GET"}
1717
target: "99"

examples/openshift/manifests/slos/slo-apiserver-read-cluster-latency.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
indicator:
1212
latency:
1313
success:
14-
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5"}
14+
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5.0"}
1515
total:
1616
metric: apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"cluster|",verb=~"LIST|GET"}
1717
target: "99"

examples/openshift/manifests/slos/slo-apiserver-read-namespace-latency.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
indicator:
1212
latency:
1313
success:
14-
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5"}
14+
metric: apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5.0"}
1515
total:
1616
metric: apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"namespace|",verb=~"LIST|GET"}
1717
target: "99"

jsonnet/pyrra/kubernetes.libsonnet

+29-24
Original file line numberDiff line numberDiff line change
@@ -155,28 +155,33 @@
155155
apiVersion: 'rbac.authorization.k8s.io/v1',
156156
kind: 'ClusterRole',
157157
metadata: pyrra._kubernetesMetadata,
158-
rules: [{
159-
apiGroups: ['monitoring.coreos.com'],
160-
resources: ['prometheusrules'],
161-
verbs: ['create', 'delete', 'get', 'list', 'patch', 'update', 'watch'],
162-
}, {
163-
apiGroups: ['monitoring.coreos.com'],
164-
resources: ['prometheusrules/status'],
165-
verbs: ['get'],
166-
}, {
167-
apiGroups: ['pyrra.dev'],
168-
resources: ['servicelevelobjectives'],
169-
verbs: ['create', 'delete', 'get', 'list', 'patch', 'update', 'watch'],
170-
}, {
171-
apiGroups: ['pyrra.dev'],
172-
resources: ['servicelevelobjectives/status'],
173-
verbs: ['get', 'patch', 'update'],
174-
},
175-
{
176-
apiGroups: ['pyrra.dev'],
177-
resources: ['servicelevelobjectives/finalizers'],
178-
verbs: ['update'],
179-
}],
158+
rules: [
159+
{
160+
apiGroups: ['monitoring.coreos.com'],
161+
resources: ['prometheusrules'],
162+
verbs: ['create', 'delete', 'get', 'list', 'patch', 'update', 'watch'],
163+
},
164+
{
165+
apiGroups: ['monitoring.coreos.com'],
166+
resources: ['prometheusrules/status'],
167+
verbs: ['get'],
168+
},
169+
{
170+
apiGroups: ['pyrra.dev'],
171+
resources: ['servicelevelobjectives'],
172+
verbs: ['create', 'delete', 'get', 'list', 'patch', 'update', 'watch'],
173+
},
174+
{
175+
apiGroups: ['pyrra.dev'],
176+
resources: ['servicelevelobjectives/status'],
177+
verbs: ['get', 'patch', 'update'],
178+
},
179+
{
180+
apiGroups: ['pyrra.dev'],
181+
resources: ['servicelevelobjectives/finalizers'],
182+
verbs: ['update'],
183+
},
184+
],
180185
},
181186

182187
kubernetesClusterRoleBinding: {
@@ -372,7 +377,7 @@
372377
indicator: {
373378
latency: {
374379
success: {
375-
metric: 'apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5"}',
380+
metric: 'apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"namespace|",verb=~"LIST|GET",le="5.0"}',
376381
},
377382
total: {
378383
metric: 'apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"namespace|",verb=~"LIST|GET"}',
@@ -400,7 +405,7 @@
400405
indicator: {
401406
latency: {
402407
success: {
403-
metric: 'apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5"}',
408+
metric: 'apiserver_request_sli_duration_seconds_bucket{component="apiserver",scope=~"cluster|",verb=~"LIST|GET",le="5.0"}',
404409
},
405410
total: {
406411
metric: 'apiserver_request_sli_duration_seconds_count{component="apiserver",scope=~"cluster|",verb=~"LIST|GET"}',

0 commit comments

Comments
 (0)