Update depguard config

Author: metalmatze

.golangci.yml

@@ -21,16 +21,23 @@ issues:
 
 linters-settings:
   depguard:
-    list-type: blacklist
-    include-go-root: true
-    packages-with-error-message:
-      - sync/atomic: "Use go.uber.org/atomic instead of sync/atomic"
-      - debug/elf: "Use github.com/parca-dev/parca/internal/go/debug/elf instead of debug/elf"
-      - github.com/stretchr/testify/assert: "Use github.com/stretchr/testify/require instead of github.com/stretchr/testify/assert"
-      - log: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
-      - github.com/go-kit/kit/log: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
-      - github.com/go-logr/logr: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
-      - github.com/pkg/errors: "Use fmt.Errorf instead"
+    rules:
+      Main:
+        deny:
+          - pkg: sync/atomic
+            desc: "Use go.uber.org/atomic instead of sync/atomic"
+          - pkg: debug/elf
+            desc: "Use github.com/parca-dev/parca/internal/go/debug/elf instead of debug/elf"
+          - pkg: github.com/stretchr/testify/assert
+            desc: "Use github.com/stretchr/testify/require instead of github.com/stretchr/testify/assert"
+          - pkg: log
+            desc: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
+          - pkg: github.com/go-kit/kit/log
+            desc: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
+          - pkg: github.com/go-logr/logr
+            desc: "Use github.com/go-kit/log instead of github.com/go-kit/kit/log"
+          - pkg: github.com/pkg/errors
+            desc: "Use fmt.Errorf instead"
   errcheck:
     exclude: ./.errcheck_excludes.txt
   goimports:

filesystem.go

@@ -276,7 +276,7 @@ type FilesystemObjectiveServer struct {
 	objectives *Objectives
 }
 
-func (s *FilesystemObjectiveServer) List(ctx context.Context, req *connect.Request[objectivesv1alpha1.ListRequest]) (*connect.Response[objectivesv1alpha1.ListResponse], error) {
+func (s *FilesystemObjectiveServer) List(_ context.Context, req *connect.Request[objectivesv1alpha1.ListRequest]) (*connect.Response[objectivesv1alpha1.ListResponse], error) {
 	var matchers []*labels.Matcher
 	if expr := req.Msg.Expr; expr != "" {
 		var err error

kubernetes.go

@@ -57,7 +57,7 @@ func init() {
 	// +kubebuilder:scaffold:scheme
 }
 
-func cmdKubernetes(logger log.Logger, metricsAddr string, configMapMode, genericRules bool) int {
+func cmdKubernetes(logger log.Logger, metricsAddr string, _, genericRules bool) int {
 	setupLog := ctrl.Log.WithName("setup")
 	ctrl.SetLogger(zap.New(zap.UseDevMode(true)))
 

kubernetes/api/v1alpha1/servicelevelobjective_types.go

@@ -168,7 +168,7 @@ func (in *ServiceLevelObjective) ValidateCreate() (admission.Warnings, error) {
 	return in.validate()
 }
 
-func (in *ServiceLevelObjective) ValidateUpdate(old runtime.Object) (admission.Warnings, error) {
+func (in *ServiceLevelObjective) ValidateUpdate(_ runtime.Object) (admission.Warnings, error) {
 	return in.validate()
 }
 

kubernetes_test.go

@@ -73,7 +73,7 @@ var (
 
 type mockClient struct{}
 
-func (m *mockClient) List(_ context.Context, list client.ObjectList, opts ...client.ListOption) error {
+func (m *mockClient) List(_ context.Context, list client.ObjectList, _ ...client.ListOption) error {
 	switch l := list.(type) {
 	case *pyrrav1alpha1.ServiceLevelObjectiveList:
 		l.Items = append(l.Items, o1)