Skip to content

Commit ec431fd

Browse files
mayeutjoerick
andauthored
Apply review suggestion
Co-authored-by: Joe Rickerby <[email protected]>
1 parent a723b83 commit ec431fd

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

cibuildwheel/options.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -674,16 +674,17 @@ def globals(self) -> GlobalOptions:
674674

675675
def _check_pinned_image(self, value: str, pinned_images: Mapping[str, str]) -> None:
676676
error_set = {"manylinux1", "manylinux2010", "manylinux_2_24", "musllinux_1_1"}
677-
warning_set = error_set # shall include error_set
677+
warning_set: set[str] = set()
678+
679+
if value in error_set:
680+
msg = (
681+
f"cibuildwheel 3.x does not support the image {value!r}. Either upgrade to a "
682+
"supported image or continue using the image by pinning it directly with"
683+
" its full OCI registry '<name>{:<tag>|@<digest>}'."
684+
)
685+
raise errors.DeprecationError(msg)
678686

679687
if value in warning_set and value not in self._image_warnings:
680-
if value in error_set:
681-
msg = (
682-
f"cibuildwheel 3.x does not support the image {value!r}. Either upgrade to a "
683-
"supported image or continue using the image by pinning it directly with"
684-
" its full OCI registry '<name>{:<tag>|@<digest>}'."
685-
)
686-
raise errors.DeprecationError(msg)
687688
self._image_warnings.add(value)
688689
msg = (
689690
f"Deprecated image {value!r}. This value will not work"

0 commit comments

Comments
 (0)