Skip to content

Commit bbc4fcd

Browse files
authored
Apply suggestions from code review
1 parent a4019d6 commit bbc4fcd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/faq.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -294,14 +294,14 @@ CIBW_BEFORE_ALL_WINDOWS: rustup target add i686-pc-windows-msvc
294294
CIBW_ENVIRONMENT_LINUX: "PATH=$HOME/.cargo/bin:$PATH"
295295
```
296296

297-
You probably need to skip PyPy (if using PyO3, anyway), and Rust does not provide Cargo for musllinux 32-bit:
297+
Rust does not provide Cargo for musllinux 32-bit, so that needs to be skipped:
298298

299299
```toml
300300
[tool.cibuildwheel]
301-
skip = ["pp*", "*-musllinux_i686"]
301+
skip = ["*-musllinux_i686"]
302302
```
303303

304-
Also see [maturin-action](https://github.com/PyO3/maturin-action) which is optimized for Rust wheels and can cross-compile (and can build 32-bit musl, for example).
304+
Also see [maturin-action](https://github.com/PyO3/maturin-action) which is optimized for Rust wheels, builds the non-Python Rust modules once, and can cross-compile (and can build 32-bit musl, for example).
305305

306306
### macOS: ModuleNotFoundError
307307

0 commit comments

Comments
 (0)