fix: try making the warnings once per Options

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

cibuildwheel/logger.py

@@ -1,5 +1,4 @@
 import codecs
-import dataclasses
 import os
 import re
 import sys
@@ -65,18 +64,16 @@ def __init__(self, *, unicode: bool) -> None:
         self.error = "✕" if unicode else "failed"
 
 
-@dataclasses.dataclass
 class Logger:
-    fold_mode: str = "disabled"
-    colors_enabled: bool = False
-    unicode_enabled: bool = False
+    fold_mode: str
+    colors_enabled: bool
+    unicode_enabled: bool
     active_build_identifier: str | None = None
     build_start_time: float | None = None
     step_start_time: float | None = None
     active_fold_group_name: str | None = None
-    deduplicate: set[str] = dataclasses.field(default_factory=set)
 
-    def __post_init__(self) -> None:
+    def __init__(self) -> None:
         if sys.platform == "win32" and hasattr(sys.stdout, "reconfigure"):
             # the encoding on Windows can be a 1-byte charmap, but all CIs
             # support utf8, so we hardcode that
@@ -99,9 +96,11 @@ def __post_init__(self) -> None:
             self.colors_enabled = True
 
         elif ci_provider == CIProvider.appveyor:
+            self.fold_mode = "disabled"
             self.colors_enabled = True
 
         else:
+            self.fold_mode = "disabled"
             self.colors_enabled = file_supports_color(sys.stdout)
 
     def build_start(self, identifier: str) -> None:
@@ -165,11 +164,7 @@ def notice(self, message: str) -> None:
             c = self.colors
             print(f"cibuildwheel: {c.bold}note{c.end}: {message}\n", file=sys.stderr)
 
-    def warning(self, message: str, *, deduplicate: bool = False) -> None:
-        if deduplicate and message in self.deduplicate:
-            return
-        self.deduplicate.add(message)
-
+    def warning(self, message: str) -> None:
         if self.fold_mode == "github":
             print(f"::warning::cibuildwheel: {message}\n", file=sys.stderr)
         else:

cibuildwheel/options.py

@@ -576,6 +576,7 @@ def __init__(
         self.command_line_arguments = command_line_arguments
         self.env = env
         self._defaults = defaults
+        self._image_warnings = set[str]()
 
         self.reader = OptionsReader(
             None if defaults else self.config_file_path,
@@ -775,19 +776,24 @@ def _compute_build_options(self, identifier: str | None) -> BuildOptions:
                         # default to manylinux2014
                         image = pinned_images["manylinux2014"]
                     elif config_value in pinned_images:
-                        if config_value in {
-                            "manylinux1",
-                            "manylinux2010",
-                            "manylinux_2_24",
-                            "musllinux_1_1",
-                        }:
+                        if (
+                            config_value
+                            in {
+                                "manylinux1",
+                                "manylinux2010",
+                                "manylinux_2_24",
+                                "musllinux_1_1",
+                            }
+                            and config_value not in self._image_warnings
+                        ):
+                            self._image_warnings.add(config_value)
                             msg = (
                                 f"Deprecated image {config_value!r}. This value will not work"
                                 " in a future version of cibuildwheel. Either upgrade to a supported"
                                 " image or continue using the deprecated image by pinning directly"
                                 f" to {pinned_images[config_value]!r}."
                             )
-                            log.warning(msg, deduplicate=True)
+                            log.warning(msg)
                         image = pinned_images[config_value]
                     else:
                         image = config_value